From: Jarkko Nikula <jhnikula@gmail.com>
To: alsa-devel@alsa-project.org
Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>,
Liam Girdwood <lrg@slimlogic.co.uk>
Subject: [PATCH 2.6.37] ASoC: Fix bias power down of non-DAPM codec
Date: Fri, 10 Dec 2010 20:53:55 +0200 [thread overview]
Message-ID: <1292007235-22090-1-git-send-email-jhnikula@gmail.com> (raw)
In-Reply-To: <20101210174227.GH3200@rakim.wolfsonmicro.main>
Currently bias of non-DAPM codec will be powered down (standby/off) whenever
there is a stream stop. This is wrong in simultaneous playback/capture since
the bias is put down immediately after stopping the first stream.
Fix this by using the codec->active count when figuring out the needed bias
level after stream stop.
Signed-off-by: Jarkko Nikula <jhnikula@gmail.com>
---
sound/soc/soc-dapm.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/sound/soc/soc-dapm.c b/sound/soc/soc-dapm.c
index 75ed649..c721502 100644
--- a/sound/soc/soc-dapm.c
+++ b/sound/soc/soc-dapm.c
@@ -944,6 +944,9 @@ static int dapm_power_widgets(struct snd_soc_codec *codec, int event)
case SND_SOC_DAPM_STREAM_RESUME:
sys_power = 1;
break;
+ case SND_SOC_DAPM_STREAM_STOP:
+ sys_power = !!codec->active;
+ break;
case SND_SOC_DAPM_STREAM_SUSPEND:
sys_power = 0;
break;
--
1.7.2.3
next prev parent reply other threads:[~2010-12-10 18:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-10 16:23 [RFC 2.6.38] ASoC: Fix bias power down of non-DAPM codec Jarkko Nikula
2010-12-10 17:42 ` Mark Brown
2010-12-10 18:53 ` Jarkko Nikula [this message]
2010-12-10 18:54 ` [RFC 2.6.38] ASoC: Fix build error caused by merging a fix for 2.6.37 into 2.6.38 Jarkko Nikula
2010-12-10 23:02 ` Liam Girdwood
2010-12-13 16:47 ` Mark Brown
2010-12-10 23:02 ` [PATCH 2.6.37] ASoC: Fix bias power down of non-DAPM codec Liam Girdwood
2010-12-13 16:37 ` Mark Brown
2010-12-10 21:25 ` tabs versus space fill Peter Hsiang
2010-12-10 21:35 ` Vasily Khoruzhick
2010-12-10 21:54 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1292007235-22090-1-git-send-email-jhnikula@gmail.com \
--to=jhnikula@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=lrg@slimlogic.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox