From: Liam Girdwood <lrg@slimlogic.co.uk>
To: Dimitris Papastamos <dp@opensource.wolfsonmicro.com>
Cc: alsa-devel@alsa-project.org,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
patches@opensource.wolfsonmicro.com
Subject: Re: [PATCH] ASoC: soc-cache: A few minor stylistic changes
Date: Tue, 14 Dec 2010 16:02:50 +0000 [thread overview]
Message-ID: <1292342570.3316.20.camel@odin> (raw)
In-Reply-To: <1292339736-8567-1-git-send-email-dp@opensource.wolfsonmicro.com>
On Tue, 2010-12-14 at 15:15 +0000, Dimitris Papastamos wrote:
> Remove redundant parentheses/spaces in the use of the sizeof
> operator.
>
> Signed-off-by: Dimitris Papastamos <dp@opensource.wolfsonmicro.com>
Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
> ---
> sound/soc/soc-cache.c | 14 +++++++-------
> 1 files changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/sound/soc/soc-cache.c b/sound/soc/soc-cache.c
> index 678fd75..0e17b40 100644
> --- a/sound/soc/soc-cache.c
> +++ b/sound/soc/soc-cache.c
> @@ -85,7 +85,7 @@ static int snd_soc_4_12_spi_write(void *control_data, const char *data,
> msg[1] = data[0];
>
> spi_message_init(&m);
> - memset(&t, 0, (sizeof t));
> + memset(&t, 0, sizeof t);
>
> t.tx_buf = &msg[0];
> t.len = len;
> @@ -166,7 +166,7 @@ static int snd_soc_7_9_spi_write(void *control_data, const char *data,
> msg[1] = data[1];
>
> spi_message_init(&m);
> - memset(&t, 0, (sizeof t));
> + memset(&t, 0, sizeof t);
>
> t.tx_buf = &msg[0];
> t.len = len;
> @@ -246,7 +246,7 @@ static int snd_soc_8_8_spi_write(void *control_data, const char *data,
> msg[1] = data[1];
>
> spi_message_init(&m);
> - memset(&t, 0, (sizeof t));
> + memset(&t, 0, sizeof t);
>
> t.tx_buf = &msg[0];
> t.len = len;
> @@ -326,7 +326,7 @@ static int snd_soc_8_16_spi_write(void *control_data, const char *data,
> msg[2] = data[2];
>
> spi_message_init(&m);
> - memset(&t, 0, (sizeof t));
> + memset(&t, 0, sizeof t);
>
> t.tx_buf = &msg[0];
> t.len = len;
> @@ -513,7 +513,7 @@ static int snd_soc_16_8_spi_write(void *control_data, const char *data,
> msg[2] = data[2];
>
> spi_message_init(&m);
> - memset(&t, 0, (sizeof t));
> + memset(&t, 0, sizeof t);
>
> t.tx_buf = &msg[0];
> t.len = len;
> @@ -633,7 +633,7 @@ static int snd_soc_16_16_spi_write(void *control_data, const char *data,
> msg[3] = data[3];
>
> spi_message_init(&m);
> - memset(&t, 0, (sizeof t));
> + memset(&t, 0, sizeof t);
>
> t.tx_buf = &msg[0];
> t.len = len;
> @@ -1342,7 +1342,7 @@ static int snd_soc_lzo_cache_init(struct snd_soc_codec *codec)
> * that register.
> */
> bmp_size = codec_drv->reg_cache_size;
> - sync_bmp = kmalloc(BITS_TO_LONGS(bmp_size) * sizeof (long),
> + sync_bmp = kmalloc(BITS_TO_LONGS(bmp_size) * sizeof(long),
> GFP_KERNEL);
> if (!sync_bmp) {
> ret = -ENOMEM;
next prev parent reply other threads:[~2010-12-14 16:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-14 15:15 [PATCH] ASoC: soc-cache: A few minor stylistic changes Dimitris Papastamos
2010-12-14 16:02 ` Liam Girdwood [this message]
2010-12-14 18:16 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1292342570.3316.20.camel@odin \
--to=lrg@slimlogic.co.uk \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=dp@opensource.wolfsonmicro.com \
--cc=patches@opensource.wolfsonmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox