alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Liam Girdwood <lrg@slimlogic.co.uk>
To: Dimitris Papastamos <dp@opensource.wolfsonmicro.com>
Cc: alsa-devel@alsa-project.org,
	Mark Brown <broonie@opensource.wolfsonmicro.com>,
	patches@opensource.wolfsonmicro.com
Subject: Re: [PATCH] ASoC: soc-cache: Fix invalid memory access during snd_soc_lzo_cache_sync()
Date: Tue, 11 Jan 2011 11:45:56 +0000	[thread overview]
Message-ID: <1294746356.3338.9.camel@odin> (raw)
In-Reply-To: <1294745042-23352-1-git-send-email-dp@opensource.wolfsonmicro.com>

On Tue, 2011-01-11 at 11:24 +0000, Dimitris Papastamos wrote:
> The size of the lzo syncing bitmap was incorrectly set to the size
> of the cache times the word size, however, the correct size is the
> size of the cache.
> 
> Signed-off-by: Dimitris Papastamos <dp@opensource.wolfsonmicro.com>
> ---
>  sound/soc/soc-cache.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/sound/soc/soc-cache.c b/sound/soc/soc-cache.c
> index a9ebc07..8c2a21a 100644
> --- a/sound/soc/soc-cache.c
> +++ b/sound/soc/soc-cache.c
> @@ -1361,7 +1361,7 @@ static int snd_soc_lzo_cache_init(struct snd_soc_codec *codec)
>  			goto err;
>  		}
>  		lzo_blocks[i]->sync_bmp = sync_bmp;
> -		lzo_blocks[i]->sync_bmp_nbits = reg_size;
> +		lzo_blocks[i]->sync_bmp_nbits = bmp_size;
>  		/* alloc the working space for the compressed block */
>  		ret = snd_soc_lzo_prepare(lzo_blocks[i]);
>  		if (ret < 0)

Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
-- 
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk

  reply	other threads:[~2011-01-11 11:46 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-11 11:24 [PATCH] ASoC: soc-cache: Fix invalid memory access during snd_soc_lzo_cache_sync() Dimitris Papastamos
2011-01-11 11:45 ` Liam Girdwood [this message]
2011-01-11 18:26 ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1294746356.3338.9.camel@odin \
    --to=lrg@slimlogic.co.uk \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=dp@opensource.wolfsonmicro.com \
    --cc=patches@opensource.wolfsonmicro.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).