From: Liam Girdwood <lrg@slimlogic.co.uk>
To: Stephen Warren <swarren@nvidia.com>
Cc: linux-tegra@vger.kernel.org, alsa-devel@alsa-project.org,
broonie@opensource.wolfsonmicro.com
Subject: Re: [PATCH] ASoC: tegra: s/IS_ERR_OR_NULL/IS_ERR/ for clk_get_sys
Date: Thu, 13 Jan 2011 13:39:25 +0000 [thread overview]
Message-ID: <1294925965.3453.6.camel@odin> (raw)
In-Reply-To: <1294775333-8372-1-git-send-email-swarren@nvidia.com>
On Tue, 2011-01-11 at 12:48 -0700, Stephen Warren wrote:
> A recent discussion on linux-arm-kernel noted that the value returned by
> clk_get_sys is an opaque token, and not strictly a pointer; it is
> meaningful only to the clock API, clients should not dereference the value,
> and the clock API must accept any non-IS_ERR value it returned.
>
> Hence, only IS_ERR is appropriate to interpret the result, not
> IS_ERR_OR_NULL.
>
> I checked that clk_get_sys in both ASoC's for-next and Tegra's for-next
> do behave as described; NULL is not returned in the case of error.
>
> Signed-off-by: Stephen Warren <swarren@nvidia.com>
Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk
next prev parent reply other threads:[~2011-01-13 13:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-11 19:48 [PATCH] ASoC: tegra: s/IS_ERR_OR_NULL/IS_ERR/ for clk_get_sys Stephen Warren
2011-01-13 13:39 ` Liam Girdwood [this message]
2011-01-13 13:58 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1294925965.3453.6.camel@odin \
--to=lrg@slimlogic.co.uk \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linux-tegra@vger.kernel.org \
--cc=swarren@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).