From: Liam Girdwood <lrg@slimlogic.co.uk>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: uclinux-dist-devel@blackfin.uclinux.org,
alsa-devel@alsa-project.org, Mike Frysinger <vapier@gentoo.org>
Subject: Re: [uclinux-dist-devel] [PATCH] ASoC: Blackfin TDM: use external frame syncs
Date: Thu, 13 Jan 2011 13:39:58 +0000 [thread overview]
Message-ID: <1294925998.3453.7.camel@odin> (raw)
In-Reply-To: <20110112171904.GF20911@opensource.wolfsonmicro.com>
On Wed, 2011-01-12 at 17:19 +0000, Mark Brown wrote:
> On Wed, Jan 12, 2011 at 12:11:44PM -0500, Mike Frysinger wrote:
> > On Wed, Jan 12, 2011 at 11:45, Mark Brown wrote:
>
> > > In that case I'd expect an update to your set_dai_fmt() operation
> > > disallowing any configuration except CBM_CFM. Though I see that's the
> > > case already so I'm kind of surprised the system worked at all -
> > > whatever CODECs you're using with the TDM DAI may well be buggy.
>
> > Sonic or perhaps Scott or Bob would have to comment. i have a limited
> > understanding of the SPORT/audio, so i can only theorize based on the
> > sparse changelogs i'm given.
>
> OK. The change is *probably* OK in itself (I have a similar changelog
> issue) but it may be pointing up an issue with the CODEC driver, it'd be
> worth investigating that too to make sure there isn't a matching issue
> on the CODEC side.
> _______________________________________________
Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk
prev parent reply other threads:[~2011-01-13 13:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-12 7:59 [PATCH] ASoC: Blackfin TDM: use external frame syncs Mike Frysinger
2011-01-12 11:12 ` Mark Brown
2011-01-12 16:36 ` [uclinux-dist-devel] " Mike Frysinger
2011-01-12 16:45 ` Mark Brown
2011-01-12 17:11 ` Mike Frysinger
2011-01-12 17:19 ` Mark Brown
2011-01-13 13:39 ` Liam Girdwood [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1294925998.3453.7.camel@odin \
--to=lrg@slimlogic.co.uk \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=uclinux-dist-devel@blackfin.uclinux.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).