* [PATCH] ASoC: Blackfin: fix DAI/SPORT config dependency issues
@ 2011-01-12 1:04 Mike Frysinger
2011-01-13 13:55 ` Mark Brown
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Mike Frysinger @ 2011-01-12 1:04 UTC (permalink / raw)
To: alsa-devel, Mark Brown; +Cc: uclinux-dist-devel, Barry Song
From: Barry Song <barry.song@analog.com>
While I2S/TDM/AC97 DAI is built-in, others are compiled as modules,
SND_BF5XX_SOC_SPORT will be module, then DAI can't get some symbols.
Except that, SND_BF5XX_AC97 depends on SND_BF5XX_SOC_AC97 too.
Signed-off-by: Barry Song <barry.song@analog.com>
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
---
sound/soc/blackfin/Kconfig | 11 ++++++-----
1 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/sound/soc/blackfin/Kconfig b/sound/soc/blackfin/Kconfig
index 3abeedd..ae40359 100644
--- a/sound/soc/blackfin/Kconfig
+++ b/sound/soc/blackfin/Kconfig
@@ -1,6 +1,7 @@
config SND_BF5XX_I2S
tristate "SoC I2S Audio for the ADI BF5xx chip"
depends on BLACKFIN
+ select SND_BF5XX_SOC_SPORT
help
Say Y or M if you want to add support for codecs attached to
the Blackfin SPORT (synchronous serial ports) interface in I2S
@@ -35,6 +36,7 @@ config SND_BFIN_AD73311_SE
config SND_BF5XX_TDM
tristate "SoC I2S(TDM mode) Audio for the ADI BF5xx chip"
depends on (BLACKFIN && SND_SOC)
+ select SND_BF5XX_SOC_SPORT
help
Say Y or M if you want to add support for codecs attached to
the Blackfin SPORT (synchronous serial ports) interface in TDM
@@ -61,6 +63,10 @@ config SND_BF5XX_SOC_AD193X
config SND_BF5XX_AC97
tristate "SoC AC97 Audio for the ADI BF5xx chip"
depends on BLACKFIN
+ select AC97_BUS
+ select SND_SOC_AC97_BUS
+ select SND_BF5XX_SOC_SPORT
+ select SND_BF5XX_SOC_AC97
help
Say Y or M if you want to add support for codecs attached to
the Blackfin SPORT (synchronous serial ports) interface in slot 16
@@ -122,17 +128,12 @@ config SND_BF5XX_SOC_SPORT
config SND_BF5XX_SOC_I2S
tristate
- select SND_BF5XX_SOC_SPORT
config SND_BF5XX_SOC_TDM
tristate
- select SND_BF5XX_SOC_SPORT
config SND_BF5XX_SOC_AC97
tristate
- select AC97_BUS
- select SND_SOC_AC97_BUS
- select SND_BF5XX_SOC_SPORT
config SND_BF5XX_SPORT_NUM
int "Set a SPORT for Sound chip"
--
1.7.4.rc1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ASoC: Blackfin: fix DAI/SPORT config dependency issues
2011-01-12 1:04 [PATCH] ASoC: Blackfin: fix DAI/SPORT config dependency issues Mike Frysinger
@ 2011-01-13 13:55 ` Mark Brown
2011-01-13 13:57 ` Liam Girdwood
2011-01-13 14:16 ` Mark Brown
2 siblings, 0 replies; 4+ messages in thread
From: Mark Brown @ 2011-01-13 13:55 UTC (permalink / raw)
To: Mike Frysinger; +Cc: uclinux-dist-devel, alsa-devel, Barry Song
On Tue, Jan 11, 2011 at 08:04:28PM -0500, Mike Frysinger wrote:
> From: Barry Song <barry.song@analog.com>
>
> While I2S/TDM/AC97 DAI is built-in, others are compiled as modules,
> SND_BF5XX_SOC_SPORT will be module, then DAI can't get some symbols.
> Except that, SND_BF5XX_AC97 depends on SND_BF5XX_SOC_AC97 too.
>
> Signed-off-by: Barry Song <barry.song@analog.com>
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
Ccing in Liam - Mike, please remember to CC maintainers on patches.
> ---
> sound/soc/blackfin/Kconfig | 11 ++++++-----
> 1 files changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/sound/soc/blackfin/Kconfig b/sound/soc/blackfin/Kconfig
> index 3abeedd..ae40359 100644
> --- a/sound/soc/blackfin/Kconfig
> +++ b/sound/soc/blackfin/Kconfig
> @@ -1,6 +1,7 @@
> config SND_BF5XX_I2S
> tristate "SoC I2S Audio for the ADI BF5xx chip"
> depends on BLACKFIN
> + select SND_BF5XX_SOC_SPORT
> help
> Say Y or M if you want to add support for codecs attached to
> the Blackfin SPORT (synchronous serial ports) interface in I2S
> @@ -35,6 +36,7 @@ config SND_BFIN_AD73311_SE
> config SND_BF5XX_TDM
> tristate "SoC I2S(TDM mode) Audio for the ADI BF5xx chip"
> depends on (BLACKFIN && SND_SOC)
> + select SND_BF5XX_SOC_SPORT
> help
> Say Y or M if you want to add support for codecs attached to
> the Blackfin SPORT (synchronous serial ports) interface in TDM
> @@ -61,6 +63,10 @@ config SND_BF5XX_SOC_AD193X
> config SND_BF5XX_AC97
> tristate "SoC AC97 Audio for the ADI BF5xx chip"
> depends on BLACKFIN
> + select AC97_BUS
> + select SND_SOC_AC97_BUS
> + select SND_BF5XX_SOC_SPORT
> + select SND_BF5XX_SOC_AC97
> help
> Say Y or M if you want to add support for codecs attached to
> the Blackfin SPORT (synchronous serial ports) interface in slot 16
> @@ -122,17 +128,12 @@ config SND_BF5XX_SOC_SPORT
>
> config SND_BF5XX_SOC_I2S
> tristate
> - select SND_BF5XX_SOC_SPORT
>
> config SND_BF5XX_SOC_TDM
> tristate
> - select SND_BF5XX_SOC_SPORT
>
> config SND_BF5XX_SOC_AC97
> tristate
> - select AC97_BUS
> - select SND_SOC_AC97_BUS
> - select SND_BF5XX_SOC_SPORT
>
> config SND_BF5XX_SPORT_NUM
> int "Set a SPORT for Sound chip"
> --
> 1.7.4.rc1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ASoC: Blackfin: fix DAI/SPORT config dependency issues
2011-01-12 1:04 [PATCH] ASoC: Blackfin: fix DAI/SPORT config dependency issues Mike Frysinger
2011-01-13 13:55 ` Mark Brown
@ 2011-01-13 13:57 ` Liam Girdwood
2011-01-13 14:16 ` Mark Brown
2 siblings, 0 replies; 4+ messages in thread
From: Liam Girdwood @ 2011-01-13 13:57 UTC (permalink / raw)
To: Mike Frysinger; +Cc: uclinux-dist-devel, alsa-devel, Mark Brown, Barry Song
On Tue, 2011-01-11 at 20:04 -0500, Mike Frysinger wrote:
> From: Barry Song <barry.song@analog.com>
>
> While I2S/TDM/AC97 DAI is built-in, others are compiled as modules,
> SND_BF5XX_SOC_SPORT will be module, then DAI can't get some symbols.
> Except that, SND_BF5XX_AC97 depends on SND_BF5XX_SOC_AC97 too.
>
> Signed-off-by: Barry Song <barry.song@analog.com>
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ASoC: Blackfin: fix DAI/SPORT config dependency issues
2011-01-12 1:04 [PATCH] ASoC: Blackfin: fix DAI/SPORT config dependency issues Mike Frysinger
2011-01-13 13:55 ` Mark Brown
2011-01-13 13:57 ` Liam Girdwood
@ 2011-01-13 14:16 ` Mark Brown
2 siblings, 0 replies; 4+ messages in thread
From: Mark Brown @ 2011-01-13 14:16 UTC (permalink / raw)
To: Mike Frysinger; +Cc: uclinux-dist-devel, alsa-devel, Barry Song
On Tue, Jan 11, 2011 at 08:04:28PM -0500, Mike Frysinger wrote:
> From: Barry Song <barry.song@analog.com>
>
> While I2S/TDM/AC97 DAI is built-in, others are compiled as modules,
> SND_BF5XX_SOC_SPORT will be module, then DAI can't get some symbols.
> Except that, SND_BF5XX_AC97 depends on SND_BF5XX_SOC_AC97 too.
Applied, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-01-13 14:16 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-01-12 1:04 [PATCH] ASoC: Blackfin: fix DAI/SPORT config dependency issues Mike Frysinger
2011-01-13 13:55 ` Mark Brown
2011-01-13 13:57 ` Liam Girdwood
2011-01-13 14:16 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).