* [PATCH] ASoC: WM8995: Fix incorrect use of snd_soc_update_bits()
@ 2011-01-19 12:55 Dimitris Papastamos
2011-01-19 13:16 ` Liam Girdwood
2011-01-19 18:49 ` Mark Brown
0 siblings, 2 replies; 3+ messages in thread
From: Dimitris Papastamos @ 2011-01-19 12:55 UTC (permalink / raw)
To: Mark Brown, Liam Girdwood; +Cc: alsa-devel, patches
In the wm8995_set_tristate() function when updating the register
bits use the value and not the register index as the value argument.
Signed-off-by: Dimitris Papastamos <dp@opensource.wolfsonmicro.com>
---
sound/soc/codecs/wm8995.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/sound/soc/codecs/wm8995.c b/sound/soc/codecs/wm8995.c
index 7d56341..67eaaec 100644
--- a/sound/soc/codecs/wm8995.c
+++ b/sound/soc/codecs/wm8995.c
@@ -1265,7 +1265,7 @@ static int wm8995_set_tristate(struct snd_soc_dai *codec_dai, int tristate)
else
val = 0;
- return snd_soc_update_bits(codec, reg, mask, reg);
+ return snd_soc_update_bits(codec, reg, mask, val);
}
/* The size in bits of the FLL divide multiplied by 10
--
1.7.3.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ASoC: WM8995: Fix incorrect use of snd_soc_update_bits()
2011-01-19 12:55 [PATCH] ASoC: WM8995: Fix incorrect use of snd_soc_update_bits() Dimitris Papastamos
@ 2011-01-19 13:16 ` Liam Girdwood
2011-01-19 18:49 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Liam Girdwood @ 2011-01-19 13:16 UTC (permalink / raw)
To: Dimitris Papastamos; +Cc: alsa-devel, Mark Brown, patches
On Wed, 2011-01-19 at 12:55 +0000, Dimitris Papastamos wrote:
> In the wm8995_set_tristate() function when updating the register
> bits use the value and not the register index as the value argument.
>
> Signed-off-by: Dimitris Papastamos <dp@opensource.wolfsonmicro.com>
> ---
Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ASoC: WM8995: Fix incorrect use of snd_soc_update_bits()
2011-01-19 12:55 [PATCH] ASoC: WM8995: Fix incorrect use of snd_soc_update_bits() Dimitris Papastamos
2011-01-19 13:16 ` Liam Girdwood
@ 2011-01-19 18:49 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2011-01-19 18:49 UTC (permalink / raw)
To: Dimitris Papastamos; +Cc: alsa-devel, patches, Liam Girdwood
On Wed, Jan 19, 2011 at 12:55:28PM +0000, Dimitris Papastamos wrote:
> In the wm8995_set_tristate() function when updating the register
> bits use the value and not the register index as the value argument.
>
> Signed-off-by: Dimitris Papastamos <dp@opensource.wolfsonmicro.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-01-19 18:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-01-19 12:55 [PATCH] ASoC: WM8995: Fix incorrect use of snd_soc_update_bits() Dimitris Papastamos
2011-01-19 13:16 ` Liam Girdwood
2011-01-19 18:49 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).