From: Tapio Vihuri <tapio.vihuri@nokia.com>
To: ext Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: randy.dunlap@oracle.com, alsa-devel@alsa-project.org,
peter.ujfalusi@nokia.com, samu.p.onkalo@nokia.com,
linux-kernel@vger.kernel.org, ilkka.koskinen@nokia.com
Subject: Re: [PATCH v4 1/3] ECI: input: introduce ECI accessory input driver
Date: Thu, 20 Jan 2011 14:17:33 +0200 [thread overview]
Message-ID: <1295525853.26257.21.camel@dell> (raw)
In-Reply-To: <20110120081117.GB2498@core.coreip.homeip.net>
On Thu, 2011-01-20 at 00:11 -0800, ext Dmitry Torokhov wrote:
> > How about KE_VSW case ? Shouldn't it be in the sparse_keymap_setup
> {}
> > also ?
> >
>
> Indeed. Does the patch below fix it?
>
Hi.
Yes it does, thank you.
Patch working (as it obviously should) OK in my environment, so
> Thanks.
>
> --
> Dmitry
>
> Input: sparse-keymap - fix KEY_VSW handling in sparse_keymap_setup
>
> From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
>
> We were forgetting to set up device capabilities for KEY_VSW entries.
>
> Reported-by: Tapio Vihuri <tapio.vihuri@nokia.com>
> Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
Tested-by: Tapio Vihuri <tapio.vihuri@nokia.com>
> ---
>
> drivers/input/sparse-keymap.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
>
> diff --git a/drivers/input/sparse-keymap.c
> b/drivers/input/sparse-keymap.c
> index a29a7812..7729e54 100644
> --- a/drivers/input/sparse-keymap.c
> +++ b/drivers/input/sparse-keymap.c
> @@ -201,6 +201,7 @@ int sparse_keymap_setup(struct input_dev *dev,
> break;
>
> case KE_SW:
> + case KE_VSW:
> __set_bit(EV_SW, dev->evbit);
> __set_bit(entry->sw.code, dev->swbit);
> break;
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
--
Tapsa
050 4876788
prev parent reply other threads:[~2011-01-20 12:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-19 12:06 [PATCH v4 0/3] input: Add support for ECI (multimedia) accessories tapio.vihuri
2011-01-19 12:06 ` [PATCH v4 1/3] ECI: input: introduce ECI accessory input driver tapio.vihuri
2011-01-19 12:06 ` [PATCH v4 2/3] ECI: introducing ECI controller driver tapio.vihuri
2011-01-19 12:06 ` [PATCH v4 3/3] ECI: adding platform data for ECI driver tapio.vihuri
2011-01-19 17:44 ` [PATCH v4 1/3] ECI: input: introduce ECI accessory input driver Dmitry Torokhov
2011-01-20 7:57 ` Tapio Vihuri
2011-01-20 8:11 ` Dmitry Torokhov
2011-01-20 12:17 ` Tapio Vihuri [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1295525853.26257.21.camel@dell \
--to=tapio.vihuri@nokia.com \
--cc=alsa-devel@alsa-project.org \
--cc=dmitry.torokhov@gmail.com \
--cc=ilkka.koskinen@nokia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peter.ujfalusi@nokia.com \
--cc=randy.dunlap@oracle.com \
--cc=samu.p.onkalo@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).