From: Liam Girdwood <lrg@slimlogic.co.uk>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Margarita Olaya Cabrera <magi.olaya@ti.com>,
Misael Lopez Cruz <misael.lopez@ti.com>,
patches@opensource.wolfsonmicro.com,
Jorge Eduardo Candelaria <jorge.candelaria@ti.com>,
alsa-devel@alsa-project.org
Subject: Re: [PATCH] ASoC: Staticise twl6040_hs_jack_report()
Date: Fri, 21 Jan 2011 16:46:38 +0000 [thread overview]
Message-ID: <1295628398.3348.305.camel@odin> (raw)
In-Reply-To: <1295559824-3837-1-git-send-email-broonie@opensource.wolfsonmicro.com>
On Thu, 2011-01-20 at 21:43 +0000, Mark Brown wrote:
> It's an internal function so shouldn't be exported (as sparse points
> out).
>
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> ---
> sound/soc/codecs/twl6040.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/sound/soc/codecs/twl6040.c b/sound/soc/codecs/twl6040.c
> index 4bbf1b1..482fcdb 100644
> --- a/sound/soc/codecs/twl6040.c
> +++ b/sound/soc/codecs/twl6040.c
> @@ -724,8 +724,8 @@ static int twl6040_power_mode_event(struct snd_soc_dapm_widget *w,
> return 0;
> }
>
> -void twl6040_hs_jack_report(struct snd_soc_codec *codec,
> - struct snd_soc_jack *jack, int report)
> +static void twl6040_hs_jack_report(struct snd_soc_codec *codec,
> + struct snd_soc_jack *jack, int report)
> {
> struct twl6040_data *priv = snd_soc_codec_get_drvdata(codec);
> int status;
Applied.
Thanks
Liam
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk
prev parent reply other threads:[~2011-01-21 16:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-20 21:43 [PATCH] ASoC: Staticise twl6040_hs_jack_report() Mark Brown
2011-01-21 16:46 ` Liam Girdwood [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1295628398.3348.305.camel@odin \
--to=lrg@slimlogic.co.uk \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=jorge.candelaria@ti.com \
--cc=magi.olaya@ti.com \
--cc=misael.lopez@ti.com \
--cc=patches@opensource.wolfsonmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).