From: Liam Girdwood <lrg@slimlogic.co.uk>
To: Stephen Warren <swarren@nvidia.com>
Cc: linux-tegra@vger.kernel.org, alsa-devel@alsa-project.org,
broonie@opensource.wolfsonmicro.com
Subject: Re: [PATCH] ASoC: Tegra: Harmony: Remove redundant !!
Date: Tue, 01 Feb 2011 14:01:09 +0000 [thread overview]
Message-ID: <1296568869.3327.13.camel@odin> (raw)
In-Reply-To: <1296496817-10128-1-git-send-email-swarren@nvidia.com>
On Mon, 2011-01-31 at 11:00 -0700, Stephen Warren wrote:
> gpio_set_value* should accept logic values not just 0 or 1. The WM8903 GPIO
> driver has been fixed to work this way, so remove the redundant !!
> previously required when it didn't accept values >1.
>
> Signed-off-by: Stephen Warren <swarren@nvidia.com>
> ---
> sound/soc/tegra/harmony.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/sound/soc/tegra/harmony.c b/sound/soc/tegra/harmony.c
> index d1faa63..11e2cb8 100644
> --- a/sound/soc/tegra/harmony.c
> +++ b/sound/soc/tegra/harmony.c
> @@ -132,7 +132,7 @@ static int harmony_event_int_spk(struct snd_soc_dapm_widget *w,
> struct harmony_audio_platform_data *pdata = harmony->pdata;
>
> gpio_set_value_cansleep(pdata->gpio_spkr_en,
> - !!SND_SOC_DAPM_EVENT_ON(event));
> + SND_SOC_DAPM_EVENT_ON(event));
>
> return 0;
> }
Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk
next prev parent reply other threads:[~2011-02-01 14:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-31 18:00 [PATCH] ASoC: Tegra: Harmony: Remove redundant !! Stephen Warren
2011-02-01 14:01 ` Liam Girdwood [this message]
2011-02-01 14:14 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1296568869.3327.13.camel@odin \
--to=lrg@slimlogic.co.uk \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linux-tegra@vger.kernel.org \
--cc=swarren@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).