From: Liam Girdwood <lrg@slimlogic.co.uk>
To: Janusz Krzysztofik <jkrzyszt@tis.icnet.pl>
Cc: alsa-devel@alsa-project.org,
Mark Brown <broonie@opensource.wolfsonmicro.com>
Subject: Re: [PATCH 2.6.38] ASoC: fill in snd_soc_pcm_runtime.card before calling snd_soc_dai_link.init()
Date: Wed, 02 Feb 2011 20:48:45 +0000 [thread overview]
Message-ID: <1296679725.3333.23.camel@odin> (raw)
In-Reply-To: <201102022111.42196.jkrzyszt@tis.icnet.pl>
On Wed, 2011-02-02 at 21:11 +0100, Janusz Krzysztofik wrote:
> The .card member of the snd_soc_pcm_runtime structure pointed to by the
> snd_soc_dai_link.init() argument used to be initialized before the
> function being called. This has changed, probably unintentionally,
> after recent refactorings. Since the function implementations are free
> to make use of this pointer, move its assignment back before the
> function is called to avoid NULL pointer dereferences.
>
> Created and tested on Amstrad Delta againts linux-2.6.38-rc2
>
> Signed-off-by: Janusz Krzysztofik <jkrzyszt@tis.icnet.pl>
Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk
next prev parent reply other threads:[~2011-02-02 20:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-02 20:11 [PATCH 2.6.38] ASoC: fill in snd_soc_pcm_runtime.card before calling snd_soc_dai_link.init() Janusz Krzysztofik
2011-02-02 20:48 ` Liam Girdwood [this message]
2011-02-03 6:47 ` Jarkko Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1296679725.3333.23.camel@odin \
--to=lrg@slimlogic.co.uk \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=jkrzyszt@tis.icnet.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).