From: Liam Girdwood <lrg@slimlogic.co.uk>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: codecs: wm8753: Fix DAI mode switching
Date: Mon, 07 Feb 2011 19:10:25 +0000 [thread overview]
Message-ID: <1297105825.3331.353.camel@odin> (raw)
In-Reply-To: <1296983051-3105-1-git-send-email-lars@metafoo.de>
On Sun, 2011-02-06 at 10:04 +0100, Lars-Peter Clausen wrote:
> The wm8753 codec supports switching between different DAI modes.
> The current drivers tries to implement this by changing the DAI driver at
> runtime. But to properly work this would require support from the ASoC core.
>
> So this patch takes a different approch on how the DAI mode switching is
> implemented.
>
> The only difference, from a driver point of view, between the different DAI modes
> is how to program the DAI format to the hardware. So what this patch is, it
> stores the current format for each DAI in the drivers private struct and when
> the DAI mode is changed the format gets simply reprogrammed according to the
> new DAI mode.
>
> Futhermore this patch restricts the changing of the DAI format to when the
> codec is inactive.
>
> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk
next prev parent reply other threads:[~2011-02-07 19:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-06 9:04 [PATCH] ASoC: codecs: wm8753: Fix DAI mode switching Lars-Peter Clausen
2011-02-07 19:10 ` Liam Girdwood [this message]
2011-02-07 19:11 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1297105825.3331.353.camel@odin \
--to=lrg@slimlogic.co.uk \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=lars@metafoo.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).