From: Liam Girdwood <lrg@slimlogic.co.uk>
To: Janusz Krzysztofik <jkrzyszt@tis.icnet.pl>
Cc: alsa-devel@alsa-project.org,
Mark Brown <broonie@opensource.wolfsonmicro.com>
Subject: Re: [PATCH 2.6.38] ASoC: CX20442: fix wrong reg_cache_default content
Date: Thu, 10 Feb 2011 23:59:57 +0000 [thread overview]
Message-ID: <1297382397.3313.102.camel@odin> (raw)
In-Reply-To: <201102101324.40463.jkrzyszt@tis.icnet.pl>
On Thu, 2011-02-10 at 13:24 +0100, Janusz Krzysztofik wrote:
> Content of the CX20442's snd_soc_codec_driver.reg_cache_default pointed
> area, introduced with my recent NULL pointer dereferece fix (commit
> f019ee5feb344ff0b22b58df4568676295aae14f), occured wrong after further
> testing, more thorough than just booting successfully. There are two
> problems with it:
>
> 1) It should read
> (1 << CX20442_TELOUT) | (1 << CX20442_MIC),
> not
> CX20442_TELOUT | CX20442_MIC.
>
> 2) While correctly matching actual codec hardware state on boot when
> fixed per 1), a few more code modifications would still be required
> to reflect that state not only into register cache, but also force
> them into DAPM pins state, otherwise an inconsitency occures which
> may prevent further codec state changes from being applied correctly.
> As a result, the phone stops ringing after reboot, until someone
> picks up the handset for the first time.
>
> Revert that reg_cache_default content to a working, previous de facto
> default value of 0, in hope this change can still be accepted as an rc
> cycle fix.
>
> Created and tested against linux-2.6.38-rc4
>
> Signed-off-by: Janusz Krzysztofik <jkrzyszt@tis.icnet.pl>
> ---
Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk
next prev parent reply other threads:[~2011-02-11 0:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-10 12:24 [PATCH 2.6.38] ASoC: CX20442: fix wrong reg_cache_default content Janusz Krzysztofik
2011-02-10 23:59 ` Liam Girdwood [this message]
2011-02-11 11:00 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1297382397.3313.102.camel@odin \
--to=lrg@slimlogic.co.uk \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=jkrzyszt@tis.icnet.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox