alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Liam Girdwood <lrg@slimlogic.co.uk>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: alsa-devel@alsa-project.org, patches@opensource.wolfsonmicro.com
Subject: Re: [PATCH 1/2] ASoC: Fix WM8958 default microphone detection argument ordering
Date: Tue, 22 Feb 2011 09:42:35 +0000	[thread overview]
Message-ID: <1298367755.3353.14.camel@odin> (raw)
In-Reply-To: <1298350326-15840-1-git-send-email-broonie@opensource.wolfsonmicro.com>

On Tue, 2011-02-22 at 04:52 +0000, Mark Brown wrote:
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> ---
>  sound/soc/codecs/wm8994.c |    5 ++---
>  1 files changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/sound/soc/codecs/wm8994.c b/sound/soc/codecs/wm8994.c
> index 4df047e..5f16870 100644
> --- a/sound/soc/codecs/wm8994.c
> +++ b/sound/soc/codecs/wm8994.c
> @@ -3012,11 +3012,10 @@ static void wm8958_default_micdet(u16 status, void *data)
>  		report |= SND_JACK_BTN_5;
>  
>  done:
> -	snd_soc_jack_report(wm8994->micdet[0].jack,
> +	snd_soc_jack_report(wm8994->micdet[0].jack, report,
>  			    SND_JACK_BTN_0 | SND_JACK_BTN_1 | SND_JACK_BTN_2 |
>  			    SND_JACK_BTN_3 | SND_JACK_BTN_4 | SND_JACK_BTN_5 |
> -			    SND_JACK_MICROPHONE | SND_JACK_VIDEOOUT,
> -			    report);
> +			    SND_JACK_MICROPHONE | SND_JACK_VIDEOOUT);
>  }
>  
>  /**

both

Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>

      parent reply	other threads:[~2011-02-22  9:42 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-22  4:52 [PATCH 1/2] ASoC: Fix WM8958 default microphone detection argument ordering Mark Brown
2011-02-22  4:52 ` [PATCH 2/2] ASoC: Simplify default WM8958 jack detection code Mark Brown
2011-02-22  9:42 ` Liam Girdwood [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1298367755.3353.14.camel@odin \
    --to=lrg@slimlogic.co.uk \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=patches@opensource.wolfsonmicro.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).