alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Arun Raghavan <arun.raghavan@collabora.co.uk>
To: alsa-devel@alsa-project.org
Cc: Brian Austin <brian.austin@cirrus.com>,
	Arun Raghavan <arun@accosted.net>
Subject: [PATCH] ALSA: hda - apply CS420X erratum fix for CS4207 only
Date: Thu,  3 Mar 2011 03:18:18 +0530	[thread overview]
Message-ID: <1299102498-29063-2-git-send-email-arun.raghavan@collabora.co.uk> (raw)
In-Reply-To: <1299102498-29063-1-git-send-email-arun.raghavan@collabora.co.uk>

From: Arun Raghavan <arun@accosted.net>

The commit a769cbcf60cee51f4431c0938acd39e7e5b76b8d
    ALSA: hda - Add errata initverb sequence for CS42xx codecs
applies a fix for a chip erratum that is specific to CS4207
unconditionally. On CS4206, this causes digital output to never be
activated.
---
 sound/pci/hda/patch_cirrus.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/sound/pci/hda/patch_cirrus.c b/sound/pci/hda/patch_cirrus.c
index a07b031..9804b09 100644
--- a/sound/pci/hda/patch_cirrus.c
+++ b/sound/pci/hda/patch_cirrus.c
@@ -1065,8 +1065,9 @@ static int cs_init(struct hda_codec *codec)
 {
 	struct cs_spec *spec = codec->spec;
 
-	/* init_verb sequence for C0/C1/C2 errata*/
-	snd_hda_sequence_write(codec, cs_errata_init_verbs);
+	/* init_verb sequence for CS4207 C0/C1/C2 errata */
+	if (codec->vendor_id == 0x10134207)
+		snd_hda_sequence_write(codec, cs_errata_init_verbs);
 
 	snd_hda_sequence_write(codec, cs_coef_init_verbs);
 
-- 
1.7.4.1

  reply	other threads:[~2011-03-02 21:48 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-01  5:06 CS4206 and S/PDIF (again) Arun Raghavan
2011-03-01  5:43 ` Arun Raghavan
2011-03-01  5:43   ` Arun Raghavan
2011-03-02 21:48 ` Arun Raghavan
2011-03-02 21:48   ` Arun Raghavan [this message]
2011-03-02 22:03     ` [PATCH] ALSA: hda - apply CS420X erratum fix for CS4207 only Austin, Brian
2011-03-03  4:58       ` Mohammad Bahathir Hashim
2011-03-03  5:27       ` Arun Raghavan
2011-03-03 12:01     ` Takashi Iwai
2011-03-03 12:20       ` Arun Raghavan
2011-03-03 13:58         ` Takashi Iwai
2011-03-03 14:07           ` Arun Raghavan
2011-03-03 14:20             ` Takashi Iwai
2011-03-03 18:49               ` Austin, Brian
2011-03-04  7:26                 ` Takashi Iwai
2011-03-03 14:13           ` Mohammad Bahathir Hashim
2011-03-02 22:02   ` CS4206 and S/PDIF (again) Austin, Brian

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1299102498-29063-2-git-send-email-arun.raghavan@collabora.co.uk \
    --to=arun.raghavan@collabora.co.uk \
    --cc=alsa-devel@alsa-project.org \
    --cc=arun@accosted.net \
    --cc=brian.austin@cirrus.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).