* [PATCH] ASoC: omap: rx51: Enable McBSP2 sidetone
@ 2011-03-09 9:25 Jarkko Nikula
2011-03-09 10:11 ` Mark Brown
0 siblings, 1 reply; 3+ messages in thread
From: Jarkko Nikula @ 2011-03-09 9:25 UTC (permalink / raw)
To: alsa-devel; +Cc: Mark Brown, Liam Girdwood
McBSP sidetone is needed in telephony applications. McBSP sidetone is a
configurable FIR filter that forms a loopback from McBSP input to output.
This patch enables the McBSP2 sidetone ALSA controls so that it can be used
on Nokia RX-51/N900.
Sidetone feature can be tested with following commands:
(set up codec input and output paths)
# Enable and configure sidetone
amixer -D hw:0 set 'McBSP2 Sidetone' on
amixer set -D hw:0 'McBSP2 Sidetone Channel 0' 32767
echo 32767 >/sys/devices/platform/omap-mcbsp.2/st_taps
# Do not loop audio via CPU
arecord -f dat >/dev/null |aplay /dev/zero
Signed-off-by: Jarkko Nikula <jhnikula@gmail.com>
---
sound/soc/omap/rx51.c | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/sound/soc/omap/rx51.c b/sound/soc/omap/rx51.c
index 055e447..d098622 100644
--- a/sound/soc/omap/rx51.c
+++ b/sound/soc/omap/rx51.c
@@ -331,6 +331,10 @@ static int rx51_aic34_init(struct snd_soc_pcm_runtime *rtd)
return err;
snd_soc_limit_volume(codec, "TPA6130A2 Headphone Playback Volume", 42);
+ err = omap_mcbsp_st_add_controls(codec, 1);
+ if (err < 0)
+ return err;
+
snd_soc_dapm_sync(dapm);
/* AV jack detection */
--
1.7.2.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ASoC: omap: rx51: Enable McBSP2 sidetone
2011-03-09 9:25 [PATCH] ASoC: omap: rx51: Enable McBSP2 sidetone Jarkko Nikula
@ 2011-03-09 10:11 ` Mark Brown
2011-03-09 11:55 ` Liam Girdwood
0 siblings, 1 reply; 3+ messages in thread
From: Mark Brown @ 2011-03-09 10:11 UTC (permalink / raw)
To: Jarkko Nikula; +Cc: alsa-devel, Liam Girdwood
On Wed, Mar 09, 2011 at 11:25:00AM +0200, Jarkko Nikula wrote:
> McBSP sidetone is needed in telephony applications. McBSP sidetone is a
> configurable FIR filter that forms a loopback from McBSP input to output.
> This patch enables the McBSP2 sidetone ALSA controls so that it can be used
> on Nokia RX-51/N900.
Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ASoC: omap: rx51: Enable McBSP2 sidetone
2011-03-09 10:11 ` Mark Brown
@ 2011-03-09 11:55 ` Liam Girdwood
0 siblings, 0 replies; 3+ messages in thread
From: Liam Girdwood @ 2011-03-09 11:55 UTC (permalink / raw)
To: Mark Brown; +Cc: alsa-devel
On Wed, 2011-03-09 at 10:11 +0000, Mark Brown wrote:
> On Wed, Mar 09, 2011 at 11:25:00AM +0200, Jarkko Nikula wrote:
> > McBSP sidetone is needed in telephony applications. McBSP sidetone is a
> > configurable FIR filter that forms a loopback from McBSP input to output.
> > This patch enables the McBSP2 sidetone ALSA controls so that it can be used
> > on Nokia RX-51/N900.
>
> Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Applied.
Thanks
Liam
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-03-09 11:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-03-09 9:25 [PATCH] ASoC: omap: rx51: Enable McBSP2 sidetone Jarkko Nikula
2011-03-09 10:11 ` Mark Brown
2011-03-09 11:55 ` Liam Girdwood
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).