Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
	Mark Brown <broonie@kernel.org>,
	Bard Liao <yung-chuan.liao@linux.intel.com>,
	Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
	bard.liao@intel.com
Cc: Linux-ALSA <alsa-devel@alsa-project.org>
Subject: Re: [PATCH 4/4] dt-bindings: audio-graph-port: ch_maps property
Date: Wed, 11 Oct 2023 16:20:55 +0200	[thread overview]
Message-ID: <12cf9f30-8639-4d08-aa34-aa92f86aebcc@kernel.org> (raw)
In-Reply-To: <875y3f8e76.wl-kuninori.morimoto.gx@renesas.com>

On 10/10/2023 03:21, Kuninori Morimoto wrote:
> This patch adds ch_maps property to enable handling CPU:Codec = N:M
> connection.
> 
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC. It might happen, that command when run on an older
kernel, gives you outdated entries. Therefore please be sure you base
your patches on recent Linux kernel.

You missed at least devicetree list (maybe more), so this won't be
tested by automated tooling. Performing review on untested code might be
a waste of time, thus I will skip this patch entirely till you follow
the process allowing the patch to be tested.

Please kindly resend and include all necessary To/Cc entries.

You got this feedback multiple times. Multiple. NAK.

> ---
>  Documentation/devicetree/bindings/sound/audio-graph-port.yaml | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/sound/audio-graph-port.yaml b/Documentation/devicetree/bindings/sound/audio-graph-port.yaml
> index 60b5e3fd1115f..dc663af784fd1 100644
> --- a/Documentation/devicetree/bindings/sound/audio-graph-port.yaml
> +++ b/Documentation/devicetree/bindings/sound/audio-graph-port.yaml
> @@ -19,6 +19,8 @@ definitions:
>      properties:
>        mclk-fs:
>          $ref: simple-card.yaml#/definitions/mclk-fs
> +      ch_maps:

No underscores in node names.

Best regards,
Krzysztof


  reply	other threads:[~2023-10-11 15:17 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-10  1:20 [PATCH 0/4] ASoC: makes CPU/Codec channel connection map more generic Kuninori Morimoto
2023-10-10  1:21 ` [PATCH 1/4] " Kuninori Morimoto
2023-10-10 13:40   ` Pierre-Louis Bossart
2023-10-10 23:26     ` Kuninori Morimoto
2023-10-10  1:21 ` [PATCH 2/4] ASoC: audio-graph-card2: add CPU:Codec = N:M support Kuninori Morimoto
2023-10-10  1:21 ` [PATCH 3/4] ASoC: audio-graph-card2-custom-sample: add CPU/Codec = N:M sample Kuninori Morimoto
2023-10-10  1:21 ` [PATCH 4/4] dt-bindings: audio-graph-port: ch_maps property Kuninori Morimoto
2023-10-11 14:20   ` Krzysztof Kozlowski [this message]
2023-10-10 13:43 ` [PATCH 0/4] ASoC: makes CPU/Codec channel connection map more generic Pierre-Louis Bossart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=12cf9f30-8639-4d08-aa34-aa92f86aebcc@kernel.org \
    --to=krzk@kernel.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=bard.liao@intel.com \
    --cc=broonie@kernel.org \
    --cc=kuninori.morimoto.gx@renesas.com \
    --cc=pierre-louis.bossart@linux.intel.com \
    --cc=yung-chuan.liao@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox