alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
* [PATCH alsa-kernel] snd-hda-codec-realtek: Add quirk for Jetway NF92
@ 2011-03-28 18:43 Forest Bond
  2011-03-29  6:59 ` Takashi Iwai
  2011-03-29  9:10 ` Paul Menzel
  0 siblings, 2 replies; 6+ messages in thread
From: Forest Bond @ 2011-03-28 18:43 UTC (permalink / raw)
  To: alsa-devel


[-- Attachment #1.1: Type: text/plain, Size: 796 bytes --]

The Jetway NF92 mainboard works with model=3stack-6ch-dig.  Add a
quirk to automatically configure the codec accordingly.

Signed-off-by: Forest Bond <forest.bond@rapidrollout.com>
---
 sound/pci/hda/patch_realtek.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index f1a03f2..6cc8378 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -18777,6 +18777,7 @@ static struct snd_pci_quirk alc662_cfg_tbl[] = {
 	SND_PCI_QUIRK_MASK(0x1854, 0xf000, 0x2000, "ASUS H13-200x",
 			   ALC663_ASUS_H13),
 	SND_PCI_QUIRK(0x1991, 0x5628, "Ordissimo EVE", ALC662_LENOVO_101E),
+	SND_PCI_QUIRK(0x16f3, 0xa625, "Jetway NF92", ALC662_3ST_6ch_DIG),
 	{}
 };
 
-- 
1.7.0.4

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH alsa-kernel] snd-hda-codec-realtek: Add quirk for Jetway NF92
  2011-03-28 18:43 [PATCH alsa-kernel] snd-hda-codec-realtek: Add quirk for Jetway NF92 Forest Bond
@ 2011-03-29  6:59 ` Takashi Iwai
  2011-03-29 13:37   ` Forest Bond
  2011-03-29  9:10 ` Paul Menzel
  1 sibling, 1 reply; 6+ messages in thread
From: Takashi Iwai @ 2011-03-29  6:59 UTC (permalink / raw)
  To: Forest Bond; +Cc: alsa-devel

At Mon, 28 Mar 2011 14:43:07 -0400,
Forest Bond wrote:
> 
> The Jetway NF92 mainboard works with model=3stack-6ch-dig.  Add a
> quirk to automatically configure the codec accordingly.

So, the auto-parser didn't work properly for your mobo?  How?


thanks,

Takashi

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH alsa-kernel] snd-hda-codec-realtek: Add quirk for Jetway NF92
  2011-03-28 18:43 [PATCH alsa-kernel] snd-hda-codec-realtek: Add quirk for Jetway NF92 Forest Bond
  2011-03-29  6:59 ` Takashi Iwai
@ 2011-03-29  9:10 ` Paul Menzel
  2011-03-29 13:36   ` Forest Bond
  1 sibling, 1 reply; 6+ messages in thread
From: Paul Menzel @ 2011-03-29  9:10 UTC (permalink / raw)
  To: alsa-devel


[-- Attachment #1.1: Type: text/plain, Size: 1234 bytes --]

Dear Forest,


Am Montag, den 28.03.2011, 14:43 -0400 schrieb Forest Bond:
> The Jetway NF92 mainboard works with model=3stack-6ch-dig.

what did not work before?

To provide additional information please run `alsa-info.sh` [1] with the
standard configuration and with your quirk applied and attach both
outputs.

> Add a quirk to automatically configure the codec accordingly.
> 
> Signed-off-by: Forest Bond <forest.bond@rapidrollout.com>

Please make sure that your From line and Signed-of-by line match.

> ---
>  sound/pci/hda/patch_realtek.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index f1a03f2..6cc8378 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -18777,6 +18777,7 @@ static struct snd_pci_quirk alc662_cfg_tbl[] = {
>  	SND_PCI_QUIRK_MASK(0x1854, 0xf000, 0x2000, "ASUS H13-200x",
>  			   ALC663_ASUS_H13),
>  	SND_PCI_QUIRK(0x1991, 0x5628, "Ordissimo EVE", ALC662_LENOVO_101E),
> +	SND_PCI_QUIRK(0x16f3, 0xa625, "Jetway NF92", ALC662_3ST_6ch_DIG),
>  	{}
>  };


Thanks,

Paul


[1] http://alsa-project.org/main/index.php/Help_To_Debug

[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH alsa-kernel] snd-hda-codec-realtek: Add quirk for Jetway NF92
  2011-03-29  9:10 ` Paul Menzel
@ 2011-03-29 13:36   ` Forest Bond
  2011-03-29 13:46     ` Paul Menzel
  0 siblings, 1 reply; 6+ messages in thread
From: Forest Bond @ 2011-03-29 13:36 UTC (permalink / raw)
  To: Paul Menzel; +Cc: alsa-devel


[-- Attachment #1.1: Type: text/plain, Size: 1058 bytes --]

Hi Paul,

Thanks for your reply.

On Tue, Mar 29, 2011 at 11:10:09AM +0200, Paul Menzel wrote:
> Am Montag, den 28.03.2011, 14:43 -0400 schrieb Forest Bond:
> > The Jetway NF92 mainboard works with model=3stack-6ch-dig.
> 
> what did not work before?

My testing notes say that the S/PDIF output did not work and the analog audio
was too quiet, but I'm no longer able to replicate.  Maybe I made a mistake
during testing.

Please disregard the patch.  Everything seems to be working fine without it.

> > Add a quirk to automatically configure the codec accordingly.
> > 
> > Signed-off-by: Forest Bond <forest.bond@rapidrollout.com>
> 
> Please make sure that your From line and Signed-of-by line match.

Okay.  I generated the patch on my work machine but my list membership is with
my personal address.  I think I can fix this by putting a From: line in the
message body (that's what some experimentation with git send-email suggests).

Thanks,
Forest
-- 
Forest Bond
http://www.alittletooquiet.net
http://www.pytagsfs.org

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH alsa-kernel] snd-hda-codec-realtek: Add quirk for Jetway NF92
  2011-03-29  6:59 ` Takashi Iwai
@ 2011-03-29 13:37   ` Forest Bond
  0 siblings, 0 replies; 6+ messages in thread
From: Forest Bond @ 2011-03-29 13:37 UTC (permalink / raw)
  To: Takashi Iwai; +Cc: alsa-devel


[-- Attachment #1.1: Type: text/plain, Size: 518 bytes --]

Hi Takashi,

On Tue, Mar 29, 2011 at 08:59:01AM +0200, Takashi Iwai wrote:
> At Mon, 28 Mar 2011 14:43:07 -0400,
> Forest Bond wrote:
> > 
> > The Jetway NF92 mainboard works with model=3stack-6ch-dig.  Add a
> > quirk to automatically configure the codec accordingly.
> 
> So, the auto-parser didn't work properly for your mobo?  How?

Please disregard my patch (see my e-mail to Paul for further explanation).

Thanks,
Forest
-- 
Forest Bond
http://www.alittletooquiet.net
http://www.pytagsfs.org

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH alsa-kernel] snd-hda-codec-realtek: Add quirk for Jetway NF92
  2011-03-29 13:36   ` Forest Bond
@ 2011-03-29 13:46     ` Paul Menzel
  0 siblings, 0 replies; 6+ messages in thread
From: Paul Menzel @ 2011-03-29 13:46 UTC (permalink / raw)
  To: alsa-devel


[-- Attachment #1.1: Type: text/plain, Size: 1150 bytes --]

Dear Forest,


thank you for reporting back.

Am Dienstag, den 29.03.2011, 09:36 -0400 schrieb Forest Bond:

> On Tue, Mar 29, 2011 at 11:10:09AM +0200, Paul Menzel wrote:
> > Am Montag, den 28.03.2011, 14:43 -0400 schrieb Forest Bond:
> > > The Jetway NF92 mainboard works with model=3stack-6ch-dig.
> > 
> > what did not work before?
> 
> My testing notes say that the S/PDIF output did not work and the analog audio
> was too quiet, but I'm no longer able to replicate.  Maybe I made a mistake
> during testing.
> 
> Please disregard the patch.  Everything seems to be working fine without it.

Great.

> > > Add a quirk to automatically configure the codec accordingly.
> > > 
> > > Signed-off-by: Forest Bond <forest.bond@rapidrollout.com>
> > 
> > Please make sure that your From line and Signed-of-by line match.
> 
> Okay.  I generated the patch on my work machine but my list membership is with
> my personal address.  I think I can fix this by putting a From: line in the
> message body (that's what some experimentation with git send-email suggests).

I think that is the way to do it.


Thanks,

Paul

[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2011-03-29 13:46 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-03-28 18:43 [PATCH alsa-kernel] snd-hda-codec-realtek: Add quirk for Jetway NF92 Forest Bond
2011-03-29  6:59 ` Takashi Iwai
2011-03-29 13:37   ` Forest Bond
2011-03-29  9:10 ` Paul Menzel
2011-03-29 13:36   ` Forest Bond
2011-03-29 13:46     ` Paul Menzel

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).