alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Lu Guanqun <guanqun.lu@intel.com>
To: alsa-devel@alsa-project.org
Cc: tiwai@suse.de, Lu Guanqun <guanqun.lu@intel.com>,
	broonie@opensource.wolfsonmicro.com, lrg@slimlogic.co.uk
Subject: [PATCH 2/2] ASoC: rename dapm_generic_apply_power()
Date: Sat,  2 Apr 2011 15:23:36 +0800	[thread overview]
Message-ID: <1301729016-355-2-git-send-email-guanqun.lu@intel.com> (raw)
In-Reply-To: <1301729016-355-1-git-send-email-guanqun.lu@intel.com>

dapm_generic_apply_power() is only called in dapm_seq_run() when w->id is
snd_soc_dapm_{input|output|hp|line|mic}. So, it's not a generic function at
all, we better rename it to reflect what it's doing.

Signed-off-by: Lu Guanqun <guanqun.lu@intel.com>
---
 sound/soc/soc-dapm.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/sound/soc/soc-dapm.c b/sound/soc/soc-dapm.c
index d511bbe..9b7ac3f 100644
--- a/sound/soc/soc-dapm.c
+++ b/sound/soc/soc-dapm.c
@@ -605,10 +605,10 @@ int dapm_reg_event(struct snd_soc_dapm_widget *w,
 }
 EXPORT_SYMBOL_GPL(dapm_reg_event);
 
-/* Standard power change method, used to apply power changes to most
- * widgets.
+/*
+ * power change method, used for input, output, hp, line, spk, mic.
  */
-static int dapm_generic_apply_power(struct snd_soc_dapm_widget *w)
+static int dapm_input_output_apply_power(struct snd_soc_dapm_widget *w)
 {
 	int ret;
 
@@ -947,7 +947,7 @@ static void dapm_seq_run(struct snd_soc_dapm_context *dapm,
 		case snd_soc_dapm_line:
 		case snd_soc_dapm_spk:
 			/* No register support currently */
-			ret = dapm_generic_apply_power(w);
+			ret = dapm_input_output_apply_power(w);
 			break;
 
 		default:
-- 
1.7.2.3

  reply	other threads:[~2011-04-02  7:23 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-02  7:23 [PATCH 1/2] ASoC: remove dapm_update_bits() Lu Guanqun
2011-04-02  7:23 ` Lu Guanqun [this message]
2011-04-02  7:35   ` [PATCH 2/2] ASoC: rename dapm_generic_apply_power() Mark Brown
2011-04-02  7:44     ` Lu Guanqun
2011-04-02  7:46       ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1301729016-355-2-git-send-email-guanqun.lu@intel.com \
    --to=guanqun.lu@intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=lrg@slimlogic.co.uk \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).