* [PATCH] ASoC: Remove excessively verbose logging on I2C write
@ 2011-04-04 5:57 Mark Brown
2011-04-05 7:33 ` Liam Girdwood
0 siblings, 1 reply; 2+ messages in thread
From: Mark Brown @ 2011-04-04 5:57 UTC (permalink / raw)
To: Liam Girdwood; +Cc: alsa-devel, patches, Mark Brown
We don't need to log every I2C transfer, and certainly not at error level.
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
---
sound/soc/soc-cache.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/sound/soc/soc-cache.c b/sound/soc/soc-cache.c
index 22b0990..5655fce 100644
--- a/sound/soc/soc-cache.c
+++ b/sound/soc/soc-cache.c
@@ -245,7 +245,6 @@ static unsigned int do_i2c_read(struct snd_soc_codec *codec,
xfer[1].buf = data;
ret = i2c_transfer(client->adapter, xfer, 2);
- dev_err(&client->dev, "i2c_transfer() returned %d\n", ret);
if (ret == 2)
return 0;
else if (ret < 0)
--
1.7.4.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ASoC: Remove excessively verbose logging on I2C write
2011-04-04 5:57 [PATCH] ASoC: Remove excessively verbose logging on I2C write Mark Brown
@ 2011-04-05 7:33 ` Liam Girdwood
0 siblings, 0 replies; 2+ messages in thread
From: Liam Girdwood @ 2011-04-05 7:33 UTC (permalink / raw)
To: Mark Brown; +Cc: alsa-devel, patches
On Mon, 2011-04-04 at 14:57 +0900, Mark Brown wrote:
> We don't need to log every I2C transfer, and certainly not at error level.
>
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> ---
> sound/soc/soc-cache.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/sound/soc/soc-cache.c b/sound/soc/soc-cache.c
> index 22b0990..5655fce 100644
> --- a/sound/soc/soc-cache.c
> +++ b/sound/soc/soc-cache.c
> @@ -245,7 +245,6 @@ static unsigned int do_i2c_read(struct snd_soc_codec *codec,
> xfer[1].buf = data;
>
> ret = i2c_transfer(client->adapter, xfer, 2);
> - dev_err(&client->dev, "i2c_transfer() returned %d\n", ret);
> if (ret == 2)
> return 0;
> else if (ret < 0)
Acked-by: Liam Girdwood <lrg@ti.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-04-05 7:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-04-04 5:57 [PATCH] ASoC: Remove excessively verbose logging on I2C write Mark Brown
2011-04-05 7:33 ` Liam Girdwood
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).