From: sudarshan.bisht@nokia.com
To: clemens@ladisch.de
Cc: alsa-devel@alsa-project.org
Subject: [PATCH 3/4 v2] alsa-lib: fixed coverity reported issues under "REVERSE_INULL" checker.
Date: Mon, 4 Apr 2011 10:27:55 +0300 [thread overview]
Message-ID: <1301902076-32126-3-git-send-email-sudarshan.bisht@nokia.com> (raw)
In-Reply-To: <1301902076-32126-1-git-send-email-sudarshan.bisht@nokia.com>
From: Sudarshan <sudarshan.bisht@nokia.com>
---
src/control/setup.c | 5 ++++-
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/src/control/setup.c b/src/control/setup.c
index eecda45..3606e5c 100644
--- a/src/control/setup.c
+++ b/src/control/setup.c
@@ -398,7 +398,7 @@ static int snd_config_get_ctl_elem_value(snd_config_t *conf,
static int add_elem(snd_sctl_t *h, snd_config_t *_conf, snd_config_t *private_data)
{
- snd_config_t *conf;
+ snd_config_t *conf = NULL ;
snd_config_iterator_t i, next;
char *tmp;
int iface = SND_CTL_ELEM_IFACE_MIXER;
@@ -412,6 +412,9 @@ static int add_elem(snd_sctl_t *h, snd_config_t *_conf, snd_config_t *private_da
snd_config_t *value = NULL, *mask = NULL;
snd_sctl_elem_t *elem = NULL;
int err;
+ /* The last parameter of snd_config_expand() is an output parameter, and
+ * it is guaranteed that this parameter is set when the function succeeds.
+ */
err = snd_config_expand(_conf, _conf, NULL, private_data, &conf);
if (err < 0)
return err;
--
1.7.0.4
next prev parent reply other threads:[~2011-04-04 7:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-04 7:27 [PATCH 1/4 v2] alsa-lib: fixed coverity reported issues under "FORWARD_NULL" checker sudarshan.bisht
2011-04-04 7:27 ` [PATCH 2/4 v2] alsa-lib: fixed coverity reported issues under "RESOURCE_LEAK" checker sudarshan.bisht
2011-04-04 7:27 ` sudarshan.bisht [this message]
2011-04-04 7:27 ` [PATCH 4/4 v2] alsa-lib: fixed coverity reported issues under "USE_AFTER_FREE" checker sudarshan.bisht
2011-04-04 8:05 ` Paul Menzel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1301902076-32126-3-git-send-email-sudarshan.bisht@nokia.com \
--to=sudarshan.bisht@nokia.com \
--cc=alsa-devel@alsa-project.org \
--cc=clemens@ladisch.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).