alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Paul Menzel <paulepanter@users.sourceforge.net>
To: alsa-devel@alsa-project.org
Subject: Re: [PATCH 3/3 v3] alsa-lib: fixed coverity reported issues under "USE_AFTER_FREE" checker.
Date: Mon, 04 Apr 2011 11:12:51 +0200	[thread overview]
Message-ID: <1301908371.3970.29.camel@mattotaupa> (raw)
In-Reply-To: <1301907239-1873-3-git-send-email-sudarshan.bisht@nokia.com>


[-- Attachment #1.1: Type: text/plain, Size: 898 bytes --]

Dear Sudarshan,


Am Montag, den 04.04.2011, 11:53 +0300 schrieb sudarshan.bisht@nokia.com:

[…]

> diff --git a/src/mixer/simple_abst.c b/src/mixer/simple_abst.c
> index 9e9aaf5..dd0dfa3 100644
> --- a/src/mixer/simple_abst.c
> +++ b/src/mixer/simple_abst.c
> @@ -336,6 +336,8 @@ int snd_mixer_simple_basic_register(snd_mixer_t
> *mixer,
>                 err = find_module(class, top);
>         if (err >= 0)
>                 err = snd_mixer_attach_hctl(mixer, priv->hctl);
> +               if (err < 0) 
> +                        goto __error;          

There are still trailing white spaces at the end of both lines. The
following command should show these to you with red color.

	git log -p --color-words

>         if (err >= 0) {
>                 priv->attach_flag = 1;
>                 err = snd_mixer_class_register(class, mixer);


Thanks,

Paul

[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

  reply	other threads:[~2011-04-04  9:12 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-04  8:53 [PATCH 1/3 v3] alsa-lib: fixed coverity reported issues under "FORWARD_NULL" checker sudarshan.bisht
2011-04-04  8:53 ` [PATCH 2/3 v3] alsa-lib: fixed coverity reported issues under "RESOURCE_LEAK" checker sudarshan.bisht
2011-04-04 17:30   ` Steve Calfee
2011-04-05  7:45     ` Sudarshan Bisht
2011-04-04  8:53 ` [PATCH 3/3 v3] alsa-lib: fixed coverity reported issues under "USE_AFTER_FREE" checker sudarshan.bisht
2011-04-04  9:12   ` Paul Menzel [this message]
2011-04-04 10:02     ` Sudarshan Bisht
2011-04-04  9:18 ` [PATCH 1/3 v3] alsa-lib: fixed coverity reported issues under "FORWARD_NULL" checker Mark Brown
2011-04-04 10:35   ` Takashi Iwai
2011-04-04 11:49     ` Mark Brown
2011-04-05  7:29   ` Sudarshan Bisht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1301908371.3970.29.camel@mattotaupa \
    --to=paulepanter@users.sourceforge.net \
    --cc=alsa-devel@alsa-project.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).