From mboxrd@z Thu Jan  1 00:00:00 1970
From: Sudarshan Bisht <sudarshan.bisht@nokia.com>
Subject: Re: [PATCH 1/3 v3] alsa-lib: fixed coverity reported
 issues under "FORWARD_NULL" checker.
Date: Tue, 05 Apr 2011 10:29:20 +0300
Message-ID: <1301988560.16314.248.camel@Sudarshan.research.nokia.com>
References: <1301907239-1873-1-git-send-email-sudarshan.bisht@nokia.com>
	<20110404091823.GA18247@sirena.org.uk>
Reply-To: sudarshan.bisht@nokia.com
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <alsa-devel-bounces@alsa-project.org>
Received: from mgw-da02.nokia.com (smtp.nokia.com [147.243.128.26])
	by alsa0.perex.cz (Postfix) with ESMTP id D07472442B
	for <alsa-devel@alsa-project.org>;
	Tue,  5 Apr 2011 09:31:41 +0200 (CEST)
In-Reply-To: <20110404091823.GA18247@sirena.org.uk>
List-Unsubscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
	<mailto:alsa-devel-request@alsa-project.org?subject=unsubscribe>
List-Archive: <http://mailman.alsa-project.org/pipermail/alsa-devel>
List-Post: <mailto:alsa-devel@alsa-project.org>
List-Help: <mailto:alsa-devel-request@alsa-project.org?subject=help>
List-Subscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
	<mailto:alsa-devel-request@alsa-project.org?subject=subscribe>
Sender: alsa-devel-bounces@alsa-project.org
Errors-To: alsa-devel-bounces@alsa-project.org
To: ext Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: alsa-devel@alsa-project.org
List-Id: alsa-devel@alsa-project.org

On Mon, 2011-04-04 at 10:18 +0100, ext Mark Brown wrote:
> On Mon, Apr 04, 2011 at 11:53:57AM +0300, sudarshan.bisht@nokia.com wrote:
> 
> > This patch has fix for situations where variable can be NULL 
> > but not been checked beforehand.
> 
> This description doesn't seem to match the patch...
> 
> > -	if (h == NULL)
> > +	if (h)
> >  		snd_dlclose(h);
> 
> This is a coding style change, the two conditions are equivalent.
> 
> >  			SNDERR("Invalid type for func %s definition", str);
> > +			err = -EINVAL;
> >  			goto _err;
> 
> This appears to be fixing an uninitialised return value error.
> 
> >  			return err;
> >  		if (periods == 1)
> >  			return -EINVAL;
> > -		if (*period_time == 0) {
> > +		if (period_time) {
> >  			err = INTERNAL(snd_pcm_hw_params_get_period_time)(hw_params, period_time, NULL);
> >  			if (err < 0)
> 
> This check alters the semantics - rather than checking if *period_time is
> non-zero we now check to see if period_time is non-NULL, paying no
> attention to the value if the pointer is set.
 If  "period_time == NULL" ( in preceding if condition) is true then "if
(*period_time == 0)" has no meaning ( causes segmentation fault ) and 
if  "*period_time == 0" ( in preceding if condition) is true then
obviously period_time will be a valid pointer and satisfy the condition.
Thats what original source
codes demands.      

> 
> There was at least one relevant fix in there but lots of the changes are
> as above.
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel