From: Sudarshan Bisht <sudarshan.bisht@nokia.com>
To: ext Steve Calfee <stevecalfee@gmail.com>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH 2/3 v3] alsa-lib: fixed coverity reported issues under "RESOURCE_LEAK" checker.
Date: Tue, 05 Apr 2011 10:45:30 +0300 [thread overview]
Message-ID: <1301989530.16314.252.camel@Sudarshan.research.nokia.com> (raw)
In-Reply-To: <4D9A0032.6010601@gmail.com>
On Mon, 2011-04-04 at 10:30 -0700, ext Steve Calfee wrote:
> On 04/04/11 01:53, sudarshan.bisht@nokia.com wrote:
>
> > @@ -1847,6 +1848,7 @@ int snd_config_delete(snd_config_t *config)
> > list_del(&config->list);
> > free(config->id);
> > free(config);
> > + config = NULL;
> > return 0;
> > }
>
> I don't see how this could be correct. You free memory, clear the
> calling param pointing to it and then return? What is the point of
> nulling the local pointer?
yes, this is not needed actually.
>
> Regards, Steve
Thanks,
-Sudarshan
next prev parent reply other threads:[~2011-04-05 7:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-04 8:53 [PATCH 1/3 v3] alsa-lib: fixed coverity reported issues under "FORWARD_NULL" checker sudarshan.bisht
2011-04-04 8:53 ` [PATCH 2/3 v3] alsa-lib: fixed coverity reported issues under "RESOURCE_LEAK" checker sudarshan.bisht
2011-04-04 17:30 ` Steve Calfee
2011-04-05 7:45 ` Sudarshan Bisht [this message]
2011-04-04 8:53 ` [PATCH 3/3 v3] alsa-lib: fixed coverity reported issues under "USE_AFTER_FREE" checker sudarshan.bisht
2011-04-04 9:12 ` Paul Menzel
2011-04-04 10:02 ` Sudarshan Bisht
2011-04-04 9:18 ` [PATCH 1/3 v3] alsa-lib: fixed coverity reported issues under "FORWARD_NULL" checker Mark Brown
2011-04-04 10:35 ` Takashi Iwai
2011-04-04 11:49 ` Mark Brown
2011-04-05 7:29 ` Sudarshan Bisht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1301989530.16314.252.camel@Sudarshan.research.nokia.com \
--to=sudarshan.bisht@nokia.com \
--cc=alsa-devel@alsa-project.org \
--cc=stevecalfee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).