alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: sudarshan.bisht@nokia.com
To: alsa-devel@alsa-project.org
Cc: tiwai@suse.de
Subject: [PATCH 1/2] alsa-lib: fixed coverity reported issues under "USE_AFTER_FREE" checker.
Date: Thu,  5 May 2011 16:05:30 +0300	[thread overview]
Message-ID: <1304600730-24895-2-git-send-email-sudarshan.bisht@nokia.com> (raw)
In-Reply-To: <1304600730-24895-1-git-send-email-sudarshan.bisht@nokia.com>

From: Sudarshan Bisht <sudarshan.bisht@nokia.com>

Coverity Static Analysis helps developers find hard-to-spot,
yet potentially crash-causing defects early in the development phase,
reducing the cost,time, and risk of software errors.

This patch has fixes for 1) a junk assignment and 2) memory freed at wrong location.

---
 src/control/control_hw.c |    1 +
 src/mixer/mixer.c        |    1 -
 2 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/src/control/control_hw.c b/src/control/control_hw.c
index cf258b4..16c4987 100644
--- a/src/control/control_hw.c
+++ b/src/control/control_hw.c
@@ -414,6 +414,7 @@ int snd_ctl_hw_open(snd_ctl_t **handle, const char *name, int card, int mode)
 	if (err < 0) {
 		close(fd);
 		free(hw);
+		return err;
 	}
 	ctl->ops = &snd_ctl_hw_ops;
 	ctl->private_data = hw;
diff --git a/src/mixer/mixer.c b/src/mixer/mixer.c
index 85d843f..5e5789a 100644
--- a/src/mixer/mixer.c
+++ b/src/mixer/mixer.c
@@ -228,7 +228,6 @@ int snd_mixer_attach_hctl(snd_mixer_t *mixer, snd_hctl_t *hctl)
 		return -ENOMEM;
 	err = snd_hctl_nonblock(hctl, 1);
 	if (err < 0) {
-		snd_hctl_close(hctl);
 		free(slave);
 		return err;
 	}
-- 
1.7.0.4

  reply	other threads:[~2011-05-05 13:05 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-05 13:05 [PATCH 2/2] alsa-lib: fixed coverity reported issues under "RESOURCE_LEAK" checker sudarshan.bisht
2011-05-05 13:05 ` sudarshan.bisht [this message]
  -- strict thread matches above, loose matches on Subject: below --
2011-05-04  9:46 sudarshan.bisht
2011-05-04  9:46 ` [PATCH 1/2] alsa-lib: fixed coverity reported issues under "USE_AFTER_FREE" checker sudarshan.bisht
2011-05-04  9:57   ` Takashi Iwai
2011-05-05 12:01     ` Sudarshan Bisht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1304600730-24895-2-git-send-email-sudarshan.bisht@nokia.com \
    --to=sudarshan.bisht@nokia.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).