alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Lars-Peter Clausen <lars@metafoo.de>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>,
	Liam Girdwood <lrg@slimlogic.co.uk>,
	Mike Frysinger <vapier@gentoo.org>
Cc: device-driver-devel@blackfin.uclinux.org,
	uclinux-dist-devel@blackfin.uclinux.org,
	alsa-devel@alsa-project.org, Lars-Peter Clausen <lars@metafoo.de>
Subject: [PATCH 4/4] ASoC: Use spi_write in do_spi_write
Date: Thu,  5 May 2011 19:52:46 +0200	[thread overview]
Message-ID: <1304617966-4410-4-git-send-email-lars@metafoo.de> (raw)
In-Reply-To: <1304617966-4410-1-git-send-email-lars@metafoo.de>

Instead of open-coding the spi transfer use spi_write.

Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
---
 sound/soc/soc-cache.c |   14 ++++----------
 1 files changed, 4 insertions(+), 10 deletions(-)

diff --git a/sound/soc/soc-cache.c b/sound/soc/soc-cache.c
index f1ee207..3897d4a 100644
--- a/sound/soc/soc-cache.c
+++ b/sound/soc/soc-cache.c
@@ -25,20 +25,14 @@ static int do_spi_write(void *control_data, const char *msg,
 			int len)
 {
 	struct spi_device *spi = control_data;
-	struct spi_transfer t;
-	struct spi_message m;
+	int ret;
 
 	if (len <= 0)
 		return 0;
 
-	spi_message_init(&m);
-	memset(&t, 0, sizeof t);
-
-	t.tx_buf = msg;
-	t.len = len;
-
-	spi_message_add_tail(&t, &m);
-	spi_sync(spi, &m);
+	ret = spi_write(spi, msg, len);
+	if (ret < 0)
+		return ret;
 
 	return len;
 }
-- 
1.7.2.5

  parent reply	other threads:[~2011-05-05 17:53 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-05 17:52 [PATCH 1/4] Blackfin: Use 8bit spi transfers for the ad1836 Lars-Peter Clausen
2011-05-05 17:52 ` [PATCH 2/4] ASoC: Do not swap upper and lower byte in snd_soc_4_12_spi_write Lars-Peter Clausen
2011-05-05 17:52 ` [PATCH 3/4] ASoC: Get rid of snd_soc_*_*_spi_write wrapper functions Lars-Peter Clausen
2011-05-12 12:25   ` Barry Song
2011-05-05 17:52 ` Lars-Peter Clausen [this message]
2011-05-05 22:56 ` [uclinux-dist-devel] [PATCH 1/4] Blackfin: Use 8bit spi transfers for the ad1836 Mike Frysinger
2011-05-06 12:28   ` Lars-Peter Clausen
2011-05-06 12:48     ` Mark Brown
2011-05-06 13:12       ` [Device-drivers-devel] " Mike Frysinger
2011-05-06 13:19       ` Lars-Peter Clausen
2011-05-06 13:26         ` Mark Brown
2011-05-06 13:31           ` Lars-Peter Clausen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1304617966-4410-4-git-send-email-lars@metafoo.de \
    --to=lars@metafoo.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=device-driver-devel@blackfin.uclinux.org \
    --cc=lrg@slimlogic.co.uk \
    --cc=uclinux-dist-devel@blackfin.uclinux.org \
    --cc=vapier@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).