From: Liam Girdwood <lrg@slimlogic.co.uk>
To: Stephen Warren <swarren@nvidia.com>
Cc: alsa-devel@alsa-project.org, broonie@opensource.wolfsonmicro.com
Subject: Re: [PATCH] ASoC: WM8903: Fix Digital Capture Volume range
Date: Tue, 10 May 2011 10:38:10 +0100 [thread overview]
Message-ID: <1305020290.3206.15.camel@odin> (raw)
In-Reply-To: <1304980323-18857-1-git-send-email-swarren@nvidia.com>
On Mon, 2011-05-09 at 16:32 -0600, Stephen Warren wrote:
> Increase the range of the Digital Capture Volume control to be 120 steps.
> Each step is 0.75dB, and the range starts at -72dB, giving a max setting
> of 18dB, which matches the latest datasheet, to the precision of the step
> size.
>
> Tested-on: Seaboard non-clamshell.
> Signed-off-by: Stephen Warren <swarren@nvidia.com>
> ---
> sound/soc/codecs/wm8903.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/sound/soc/codecs/wm8903.c b/sound/soc/codecs/wm8903.c
> index f3cab84..957cd66 100644
> --- a/sound/soc/codecs/wm8903.c
> +++ b/sound/soc/codecs/wm8903.c
> @@ -699,7 +699,7 @@ SOC_ENUM("DRC Smoothing Threshold", drc_smoothing),
> SOC_SINGLE_TLV("DRC Startup Volume", WM8903_DRC_0, 6, 18, 0, drc_tlv_startup),
>
> SOC_DOUBLE_R_TLV("Digital Capture Volume", WM8903_ADC_DIGITAL_VOLUME_LEFT,
> - WM8903_ADC_DIGITAL_VOLUME_RIGHT, 1, 96, 0, digital_tlv),
> + WM8903_ADC_DIGITAL_VOLUME_RIGHT, 1, 120, 0, digital_tlv),
> SOC_ENUM("ADC Companding Mode", adc_companding),
> SOC_SINGLE("ADC Companding Switch", WM8903_AUDIO_INTERFACE_0, 3, 1, 0),
>
Acked-by: Liam Girdwood <lrg@ti.com>
next prev parent reply other threads:[~2011-05-10 9:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-09 22:32 [PATCH] ASoC: WM8903: Fix Digital Capture Volume range Stephen Warren
2011-05-10 9:38 ` Liam Girdwood [this message]
2011-05-10 9:49 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1305020290.3206.15.camel@odin \
--to=lrg@slimlogic.co.uk \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=swarren@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).