alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Liam Girdwood <lrg@slimlogic.co.uk>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Felipe@alsa-project.org, alsa-devel@alsa-project.org,
	patches@opensource.wolfsonmicro.com, Balbi <balbi@ti.com>,
	Janusz Krzysztofik <jkrzyszt@tis.icnet.pl>
Subject: Re: [PATCH] ASoC: Update cx20442 for TTY API change
Date: Wed, 11 May 2011 14:33:59 +0100	[thread overview]
Message-ID: <1305120839.3277.15.camel@odin> (raw)
In-Reply-To: <1305099643-10536-1-git-send-email-broonie@opensource.wolfsonmicro.com>

On Wed, 2011-05-11 at 09:40 +0200, Mark Brown wrote:
> receive_buf() was recently changed to return the number of bytes
> received but the cx20442 driver wasn't updated to match the new API.
> I don't have any hardware but since we don't actually appears to be
> listening to the data at all just report that we accepted all the data
> that was offered to us.
> 
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> ---
>  sound/soc/codecs/cx20442.c |    8 +++++---
>  1 files changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/sound/soc/codecs/cx20442.c b/sound/soc/codecs/cx20442.c
> index d68ea53..f8c663d 100644
> --- a/sound/soc/codecs/cx20442.c
> +++ b/sound/soc/codecs/cx20442.c
> @@ -262,14 +262,14 @@ static int v253_hangup(struct tty_struct *tty)
>  }
>  
>  /* Line discipline .receive_buf() */
> -static void v253_receive(struct tty_struct *tty,
> -				const unsigned char *cp, char *fp, int count)
> +static unsigned int v253_receive(struct tty_struct *tty,
> +				 const unsigned char *cp, char *fp, int count)
>  {
>  	struct snd_soc_codec *codec = tty->disc_data;
>  	struct cx20442_priv *cx20442;
>  
>  	if (!codec)
> -		return;
> +		return count;
>  
>  	cx20442 = snd_soc_codec_get_drvdata(codec);
>  
> @@ -281,6 +281,8 @@ static void v253_receive(struct tty_struct *tty,
>  		codec->hw_write = (hw_write_t)tty->ops->write;
>  		codec->card->pop_time = 1;
>  	}
> +
> +	return count;
>  }
>  
>  /* Line discipline .write_wakeup() */

Acked-by: Liam Girdwood <lrg@ti.com>

  parent reply	other threads:[~2011-05-11 13:34 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-11  7:40 [PATCH] ASoC: Update cx20442 for TTY API change Mark Brown
2011-05-11  8:45 ` Felipe Balbi
2011-05-11 13:33 ` Liam Girdwood [this message]
2011-05-12  0:01 ` Janusz Krzysztofik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1305120839.3277.15.camel@odin \
    --to=lrg@slimlogic.co.uk \
    --cc=Felipe@alsa-project.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=balbi@ti.com \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=jkrzyszt@tis.icnet.pl \
    --cc=patches@opensource.wolfsonmicro.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).