From: Liam Girdwood <lrg@slimlogic.co.uk>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: alsa-devel@alsa-project.org, patches@opensource.wolfsonmicro.com
Subject: Re: [PATCH] ASoC: Don't squash 16x8 registers down to 8 bits
Date: Wed, 11 May 2011 14:37:37 +0100 [thread overview]
Message-ID: <1305121057.3277.17.camel@odin> (raw)
In-Reply-To: <1305114508-6705-1-git-send-email-broonie@opensource.wolfsonmicro.com>
On Wed, 2011-05-11 at 13:48 +0200, Mark Brown wrote:
> Currently we'll force all registers to fit in 8 bits before passing
> down to the I/O function. Looks like a cut'n'paste bug.
>
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> ---
> sound/soc/soc-cache.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/sound/soc/soc-cache.c b/sound/soc/soc-cache.c
> index bb8e446..40548ce 100644
> --- a/sound/soc/soc-cache.c
> +++ b/sound/soc/soc-cache.c
> @@ -232,7 +232,6 @@ static int snd_soc_16_8_write(struct snd_soc_codec *codec, unsigned int reg,
> data[0] = (reg >> 8) & 0xff;
> data[1] = reg & 0xff;
> data[2] = value;
> - reg &= 0xff;
>
> return do_hw_write(codec, reg, value, data, 3);
> }
Acked-by: Liam Girdwood <lrg@ti.com>
prev parent reply other threads:[~2011-05-11 13:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-11 11:48 [PATCH] ASoC: Don't squash 16x8 registers down to 8 bits Mark Brown
2011-05-11 13:37 ` Liam Girdwood [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1305121057.3277.17.camel@odin \
--to=lrg@slimlogic.co.uk \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=patches@opensource.wolfsonmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).