From: Mike Frysinger <vapier@gentoo.org>
To: alsa-devel@alsa-project.org, Liam Girdwood <lrg@slimlogic.co.uk>,
Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Lars-Peter Clausen <lars@metafoo.de>,
device-drivers-devel@blackfin.uclinux.org
Subject: [PATCH 1/5] ASoC: AD1836: drop unnecessary spi register check
Date: Wed, 15 Jun 2011 15:29:19 -0400 [thread overview]
Message-ID: <1308166163-22355-2-git-send-email-vapier@gentoo.org> (raw)
In-Reply-To: <1308166163-22355-1-git-send-email-vapier@gentoo.org>
The only thing the init func does is register a spi driver, so if that
fails, we return the value back up to the caller who will display an
error message for us. So drop the redundant checking/message.
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
---
sound/soc/codecs/ad1836.c | 10 +---------
1 files changed, 1 insertions(+), 9 deletions(-)
diff --git a/sound/soc/codecs/ad1836.c b/sound/soc/codecs/ad1836.c
index e3a9493..afe09b3 100644
--- a/sound/soc/codecs/ad1836.c
+++ b/sound/soc/codecs/ad1836.c
@@ -394,15 +394,7 @@ static struct spi_driver ad1836_spi_driver = {
static int __init ad1836_init(void)
{
- int ret;
-
- ret = spi_register_driver(&ad1836_spi_driver);
- if (ret != 0) {
- printk(KERN_ERR "Failed to register ad1836 SPI driver: %d\n",
- ret);
- }
-
- return ret;
+ return spi_register_driver(&ad1836_spi_driver);
}
module_init(ad1836_init);
--
1.7.5.3
next prev parent reply other threads:[~2011-06-15 19:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-15 19:29 [PATCH 0/5] AD1836 updates part two Mike Frysinger
2011-06-15 19:29 ` Mike Frysinger [this message]
2011-06-15 19:29 ` [PATCH 2/5] ASoC: AD1836: fix intermixed tab/space indentation Mike Frysinger
2011-06-15 19:29 ` [PATCH 3/5] ASoC: AD1836: fix codec name Mike Frysinger
2011-06-15 19:29 ` [PATCH 4/5] ASoC: AD1836: rename suspend/resume funcs Mike Frysinger
2011-06-15 19:29 ` [PATCH 5/5] ASoC: AD1836: clean up comment headers Mike Frysinger
2011-06-16 8:35 ` [PATCH 0/5] AD1836 updates part two Liam Girdwood
2011-06-16 10:42 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1308166163-22355-2-git-send-email-vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=device-drivers-devel@blackfin.uclinux.org \
--cc=lars@metafoo.de \
--cc=lrg@slimlogic.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox