Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Ashish Chavan <ashish.chavan@kpitcummins.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>
Subject: Re: What is correct way to put conditional stuff in ASoC codec driver?
Date: Tue, 5 Jul 2011 19:55:22 +0530	[thread overview]
Message-ID: <1309875922.15931.169.camel@matrix> (raw)
In-Reply-To: <20110704223419.GA1030@opensource.wolfsonmicro.com>

On Tue, 2011-07-05 at 04:04 +0530, Mark Brown wrote:
> > Do you mean the requirement of having interdependent codec functionality
> > is unusual? If yes, then it is something different that what I expected
> 
> Yes, or at least the need to actually worry about it is.

OK, I will stop worrying about it as of now and concentrate on other
stuff :-)

> > (1) Going through data sheets of some of Wolfsons' codecs to find out if
> > they have similar inter dependent functional blocks.
> 
> There should be no need to look at one particular vendor.

I just selected Wolfson because their ASoC codec drivers are in majority
if I look at sound/soc/codecs dir. So in my opinion, it just raises the
probability of finding the required thing.

> | You'd need to implement custom controls for the relevant enables which
> | check to see what is currently enabled and prevents enables if there
> | are conflicts.  You should do this dynamically and I'd expect that only

Yes, I got what you meant here and after some homework also found the
example of this. You are trying to convey something similar to what is
done within "outmixer_event()" function of sound/soc/codecs/wm8991.c (at
lest the condition checking part), right?

> All you're doing is trying to restrict the values that can be set on a
> control dynamically.

I think, it is more about restricting access to a set of controls
dynamically based of enable/disable of some other control(s).

I guess now I have enough details to start off implementation part. I
will pop up a query again, if I am stuck somewhere.

BTW thanks for helping me out in getting things clear. 

  reply	other threads:[~2011-07-05 14:18 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-30 12:46 What is correct way to put conditional stuff in ASoC codec driver? Ashish Chavan
2011-06-30 16:37 ` Mark Brown
2011-07-01  8:33   ` Ashish Chavan
2011-07-01 16:17     ` Mark Brown
2011-07-04  6:56       ` Ashish Chavan
2011-07-04 22:34         ` Mark Brown
2011-07-05 14:25           ` Ashish Chavan [this message]
2011-07-05 19:37             ` Mark Brown
2011-07-07 11:50               ` Ashish Chavan
2011-07-07 15:49                 ` Mark Brown
2011-07-11 14:16                   ` Ashish Chavan
2011-07-11 14:17                     ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1309875922.15931.169.camel@matrix \
    --to=ashish.chavan@kpitcummins.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox