From: Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org>
To: Jaroslav Kysela <perex-/Fr2/VpizcU@public.gmane.org>
Cc: Takashi Iwai <tiwai-l3A5Bk7waGM@public.gmane.org>,
alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Linux USB Mailing List
<linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org>
Subject: [PATCH] sound: usb: mixer: increase control transfer timeout
Date: Mon, 29 Aug 2011 14:10:26 +0300 [thread overview]
Message-ID: <1314616226-15942-1-git-send-email-balbi@ti.com> (raw)
100ms might not be enough for slower devices. Increasing
timeout to 1000ms doesn't seem like overkill.
Signed-off-by: Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org>
---
Not sure this information is valid on a commit log, but I
have a FPGA-platform which I use to test my USB controller
and when that's running on FS, this message fails because
control message times out before controller has the opportunity
to complete all three phases of the SETUP transaction.
sound/usb/mixer.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/sound/usb/mixer.c b/sound/usb/mixer.c
index cdd19d7..a3cbc98 100644
--- a/sound/usb/mixer.c
+++ b/sound/usb/mixer.c
@@ -296,7 +296,7 @@ static int get_ctl_value_v1(struct usb_mixer_elem_info *cval, int request, int v
if (snd_usb_ctl_msg(chip->dev, usb_rcvctrlpipe(chip->dev, 0), request,
USB_RECIP_INTERFACE | USB_TYPE_CLASS | USB_DIR_IN,
validx, snd_usb_ctrl_intf(chip) | (cval->id << 8),
- buf, val_len, 100) >= val_len) {
+ buf, val_len, 1000) >= val_len) {
*value_ret = convert_signed_value(cval, snd_usb_combine_bytes(buf, val_len));
snd_usb_autosuspend(cval->mixer->chip);
return 0;
--
1.7.6.396.ge0613
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next reply other threads:[~2011-08-29 11:10 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-29 11:10 Felipe Balbi [this message]
[not found] ` <1314616226-15942-1-git-send-email-balbi-l0cyMroinI0@public.gmane.org>
2011-08-29 11:16 ` [PATCH] sound: usb: mixer: increase control transfer timeout Sebastian Andrzej Siewior
[not found] ` <20110829111607.GB21556-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
2011-08-29 11:19 ` Felipe Balbi
2011-08-29 11:58 ` Clemens Ladisch
[not found] ` <4E5B7EE7.6070103-P6GI/4k7KOmELgA04lAiVw@public.gmane.org>
2011-08-29 12:23 ` Felipe Balbi
2011-08-29 12:31 ` [PATCH v2] " Felipe Balbi
2011-08-29 12:37 ` Jassi Brar
[not found] ` <CABb+yY15qrszsbJSGGFra7mrVRO_oQPUhNT=U7TNpyoYikABPw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-08-29 13:00 ` Felipe Balbi
2011-08-29 13:34 ` Jassi Brar
2011-08-29 14:05 ` Clemens Ladisch
[not found] ` <4E5B9CB0.4090708-P6GI/4k7KOmELgA04lAiVw@public.gmane.org>
2011-08-29 14:22 ` Jassi Brar
2011-09-12 10:57 ` Takashi Iwai
2011-09-16 6:25 ` [PATCH] " Takashi Iwai
2011-09-26 8:49 ` Felipe Balbi
2011-09-27 6:52 ` Clemens Ladisch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1314616226-15942-1-git-send-email-balbi@ti.com \
--to=balbi-l0cymroini0@public.gmane.org \
--cc=alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=perex-/Fr2/VpizcU@public.gmane.org \
--cc=tiwai-l3A5Bk7waGM@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).