* [PATCH 2/4] ASoC: Staticise bf5xx_pcm_i2s_new()
2011-09-21 6:40 [PATCH 1/4] ASoC: Staticise bf5xx_pcm_ac97_new() Axel Lin
@ 2011-09-21 6:40 ` Axel Lin
2011-09-21 6:41 ` [PATCH 3/4] ASoC: Staticise jz4740_pcm_new() Axel Lin
` (2 subsequent siblings)
3 siblings, 0 replies; 7+ messages in thread
From: Axel Lin @ 2011-09-21 6:40 UTC (permalink / raw)
To: linux-kernel; +Cc: Cliff Cai, Liam Girdwood, Mark Brown, alsa-devel
It is not used outside this driver so no need to make the symbol global.
Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
sound/soc/blackfin/bf5xx-i2s-pcm.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/sound/soc/blackfin/bf5xx-i2s-pcm.c b/sound/soc/blackfin/bf5xx-i2s-pcm.c
index 61ddf94..7565e15 100644
--- a/sound/soc/blackfin/bf5xx-i2s-pcm.c
+++ b/sound/soc/blackfin/bf5xx-i2s-pcm.c
@@ -257,7 +257,7 @@ static void bf5xx_pcm_free_dma_buffers(struct snd_pcm *pcm)
static u64 bf5xx_pcm_dmamask = DMA_BIT_MASK(32);
-int bf5xx_pcm_i2s_new(struct snd_soc_pcm_runtime *rtd)
+static int bf5xx_pcm_i2s_new(struct snd_soc_pcm_runtime *rtd)
{
struct snd_card *card = rtd->card->snd_card;
struct snd_soc_dai *dai = rtd->cpu_dai;
--
1.7.4.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH 3/4] ASoC: Staticise jz4740_pcm_new()
2011-09-21 6:40 [PATCH 1/4] ASoC: Staticise bf5xx_pcm_ac97_new() Axel Lin
2011-09-21 6:40 ` [PATCH 2/4] ASoC: Staticise bf5xx_pcm_i2s_new() Axel Lin
@ 2011-09-21 6:41 ` Axel Lin
2011-09-21 14:09 ` Lars-Peter Clausen
2011-09-21 6:42 ` [PATCH 4/4] ASoC: Staticise nuc900_dma_getposition() Axel Lin
2011-09-21 13:56 ` [PATCH 1/4] ASoC: Staticise bf5xx_pcm_ac97_new() Mark Brown
3 siblings, 1 reply; 7+ messages in thread
From: Axel Lin @ 2011-09-21 6:41 UTC (permalink / raw)
To: linux-kernel; +Cc: Lars-Peter Clausen, Liam Girdwood, Mark Brown, alsa-devel
It is not used outside this driver so no need to make the symbol global.
Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
sound/soc/jz4740/jz4740-pcm.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/sound/soc/jz4740/jz4740-pcm.c b/sound/soc/jz4740/jz4740-pcm.c
index a7c9578..d1989cd 100644
--- a/sound/soc/jz4740/jz4740-pcm.c
+++ b/sound/soc/jz4740/jz4740-pcm.c
@@ -299,7 +299,7 @@ static void jz4740_pcm_free(struct snd_pcm *pcm)
static u64 jz4740_pcm_dmamask = DMA_BIT_MASK(32);
-int jz4740_pcm_new(struct snd_soc_pcm_runtime *rtd)
+static int jz4740_pcm_new(struct snd_soc_pcm_runtime *rtd)
{
struct snd_card *card = rtd->card->snd_card;
struct snd_soc_dai *dai = rtd->cpu_dai;
--
1.7.4.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH 3/4] ASoC: Staticise jz4740_pcm_new()
2011-09-21 6:41 ` [PATCH 3/4] ASoC: Staticise jz4740_pcm_new() Axel Lin
@ 2011-09-21 14:09 ` Lars-Peter Clausen
0 siblings, 0 replies; 7+ messages in thread
From: Lars-Peter Clausen @ 2011-09-21 14:09 UTC (permalink / raw)
To: Axel Lin; +Cc: linux-kernel, Liam Girdwood, Mark Brown, alsa-devel
On 09/21/2011 08:41 AM, Axel Lin wrote:
> It is not used outside this driver so no need to make the symbol global.
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
Acked-by: Lars-Peter Clausen <lars@metafoo.de>
Thanks.
> ---
> sound/soc/jz4740/jz4740-pcm.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/sound/soc/jz4740/jz4740-pcm.c b/sound/soc/jz4740/jz4740-pcm.c
> index a7c9578..d1989cd 100644
> --- a/sound/soc/jz4740/jz4740-pcm.c
> +++ b/sound/soc/jz4740/jz4740-pcm.c
> @@ -299,7 +299,7 @@ static void jz4740_pcm_free(struct snd_pcm *pcm)
>
> static u64 jz4740_pcm_dmamask = DMA_BIT_MASK(32);
>
> -int jz4740_pcm_new(struct snd_soc_pcm_runtime *rtd)
> +static int jz4740_pcm_new(struct snd_soc_pcm_runtime *rtd)
> {
> struct snd_card *card = rtd->card->snd_card;
> struct snd_soc_dai *dai = rtd->cpu_dai;
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 4/4] ASoC: Staticise nuc900_dma_getposition()
2011-09-21 6:40 [PATCH 1/4] ASoC: Staticise bf5xx_pcm_ac97_new() Axel Lin
2011-09-21 6:40 ` [PATCH 2/4] ASoC: Staticise bf5xx_pcm_i2s_new() Axel Lin
2011-09-21 6:41 ` [PATCH 3/4] ASoC: Staticise jz4740_pcm_new() Axel Lin
@ 2011-09-21 6:42 ` Axel Lin
2011-09-21 6:49 ` Wan ZongShun
2011-09-21 13:56 ` [PATCH 1/4] ASoC: Staticise bf5xx_pcm_ac97_new() Mark Brown
3 siblings, 1 reply; 7+ messages in thread
From: Axel Lin @ 2011-09-21 6:42 UTC (permalink / raw)
To: linux-kernel; +Cc: Wan ZongShun, Liam Girdwood, Mark Brown, alsa-devel
It is not used outside this driver so no need to make the symbol global.
Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
sound/soc/nuc900/nuc900-pcm.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/sound/soc/nuc900/nuc900-pcm.c b/sound/soc/nuc900/nuc900-pcm.c
index e46d551..4e3626b 100644
--- a/sound/soc/nuc900/nuc900-pcm.c
+++ b/sound/soc/nuc900/nuc900-pcm.c
@@ -227,7 +227,7 @@ static int nuc900_dma_trigger(struct snd_pcm_substream *substream, int cmd)
return ret;
}
-int nuc900_dma_getposition(struct snd_pcm_substream *substream,
+static int nuc900_dma_getposition(struct snd_pcm_substream *substream,
dma_addr_t *src, dma_addr_t *dst)
{
struct snd_pcm_runtime *runtime = substream->runtime;
--
1.7.4.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH 4/4] ASoC: Staticise nuc900_dma_getposition()
2011-09-21 6:42 ` [PATCH 4/4] ASoC: Staticise nuc900_dma_getposition() Axel Lin
@ 2011-09-21 6:49 ` Wan ZongShun
0 siblings, 0 replies; 7+ messages in thread
From: Wan ZongShun @ 2011-09-21 6:49 UTC (permalink / raw)
To: Axel Lin; +Cc: alsa-devel, Mark Brown, linux-kernel, Liam Girdwood
2011/9/21 Axel Lin <axel.lin@gmail.com>:
> It is not used outside this driver so no need to make the symbol global.
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> ---
> sound/soc/nuc900/nuc900-pcm.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/sound/soc/nuc900/nuc900-pcm.c b/sound/soc/nuc900/nuc900-pcm.c
> index e46d551..4e3626b 100644
> --- a/sound/soc/nuc900/nuc900-pcm.c
> +++ b/sound/soc/nuc900/nuc900-pcm.c
> @@ -227,7 +227,7 @@ static int nuc900_dma_trigger(struct snd_pcm_substream *substream, int cmd)
> return ret;
> }
>
> -int nuc900_dma_getposition(struct snd_pcm_substream *substream,
> +static int nuc900_dma_getposition(struct snd_pcm_substream *substream,
> dma_addr_t *src, dma_addr_t *dst)
> {
> struct snd_pcm_runtime *runtime = substream->runtime;
> --
> 1.7.4.1
>
thanks!
Acked- by: Wan Zongshun <mcuos.com@gmail.com>
>
>
>
--
Wan ZongShun.
www.mcuos.com
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/4] ASoC: Staticise bf5xx_pcm_ac97_new()
2011-09-21 6:40 [PATCH 1/4] ASoC: Staticise bf5xx_pcm_ac97_new() Axel Lin
` (2 preceding siblings ...)
2011-09-21 6:42 ` [PATCH 4/4] ASoC: Staticise nuc900_dma_getposition() Axel Lin
@ 2011-09-21 13:56 ` Mark Brown
3 siblings, 0 replies; 7+ messages in thread
From: Mark Brown @ 2011-09-21 13:56 UTC (permalink / raw)
To: Axel Lin; +Cc: Cliff Cai, linux-kernel, alsa-devel, Liam Girdwood
On Wed, Sep 21, 2011 at 02:40:05PM +0800, Axel Lin wrote:
> It is not used outside this driver so no need to make the symbol global.
All applied, thanks.
^ permalink raw reply [flat|nested] 7+ messages in thread