* [PATCH 1/2] ASoC: Remove unused fields in struct mfld_mc_private
@ 2011-09-27 2:38 Axel Lin
2011-09-27 2:38 ` [PATCH 2/2] ASoC: Staticise sst_platform_dai Axel Lin
2011-09-27 10:21 ` [PATCH 1/2] ASoC: Remove unused fields in struct mfld_mc_private Mark Brown
0 siblings, 2 replies; 4+ messages in thread
From: Axel Lin @ 2011-09-27 2:38 UTC (permalink / raw)
To: linux-kernel
Cc: Vinod Koul, Harsha Priya, Liam Girdwood, Mark Brown, alsa-devel
Both *socdev and *codec of struct mfld_mc_private are not being used
in this driver, remove it.
Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
sound/soc/mid-x86/mfld_machine.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/sound/soc/mid-x86/mfld_machine.c b/sound/soc/mid-x86/mfld_machine.c
index 429aa1b..1d818dc 100644
--- a/sound/soc/mid-x86/mfld_machine.c
+++ b/sound/soc/mid-x86/mfld_machine.c
@@ -54,9 +54,7 @@ static unsigned int hs_switch;
static unsigned int lo_dac;
struct mfld_mc_private {
- struct platform_device *socdev;
void __iomem *int_base;
- struct snd_soc_codec *codec;
u8 interrupt_status;
};
--
1.7.4.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH 2/2] ASoC: Staticise sst_platform_dai
2011-09-27 2:38 [PATCH 1/2] ASoC: Remove unused fields in struct mfld_mc_private Axel Lin
@ 2011-09-27 2:38 ` Axel Lin
2011-09-27 10:22 ` Mark Brown
2011-09-27 10:21 ` [PATCH 1/2] ASoC: Remove unused fields in struct mfld_mc_private Mark Brown
1 sibling, 1 reply; 4+ messages in thread
From: Axel Lin @ 2011-09-27 2:38 UTC (permalink / raw)
To: linux-kernel
Cc: Vinod Koul, Harsha Priya, Liam Girdwood, Mark Brown, alsa-devel
It is not used outside this driver so no need to make the symbol global.
Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
sound/soc/mid-x86/sst_platform.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/sound/soc/mid-x86/sst_platform.c b/sound/soc/mid-x86/sst_platform.c
index 9925d20..7df8c58 100644
--- a/sound/soc/mid-x86/sst_platform.c
+++ b/sound/soc/mid-x86/sst_platform.c
@@ -63,7 +63,7 @@ static struct snd_pcm_hardware sst_platform_pcm_hw = {
};
/* MFLD - MSIC */
-struct snd_soc_dai_driver sst_platform_dai[] = {
+static struct snd_soc_dai_driver sst_platform_dai[] = {
{
.name = "Headset-cpu-dai",
.id = 0,
--
1.7.4.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH 1/2] ASoC: Remove unused fields in struct mfld_mc_private
2011-09-27 2:38 [PATCH 1/2] ASoC: Remove unused fields in struct mfld_mc_private Axel Lin
2011-09-27 2:38 ` [PATCH 2/2] ASoC: Staticise sst_platform_dai Axel Lin
@ 2011-09-27 10:21 ` Mark Brown
1 sibling, 0 replies; 4+ messages in thread
From: Mark Brown @ 2011-09-27 10:21 UTC (permalink / raw)
To: Axel Lin
Cc: Vinod Koul, alsa-devel, Harsha Priya, linux-kernel, Liam Girdwood
On Tue, Sep 27, 2011 at 10:38:07AM +0800, Axel Lin wrote:
> Both *socdev and *codec of struct mfld_mc_private are not being used
> in this driver, remove it.
Applied, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-09-27 10:22 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-09-27 2:38 [PATCH 1/2] ASoC: Remove unused fields in struct mfld_mc_private Axel Lin
2011-09-27 2:38 ` [PATCH 2/2] ASoC: Staticise sst_platform_dai Axel Lin
2011-09-27 10:22 ` Mark Brown
2011-09-27 10:21 ` [PATCH 1/2] ASoC: Remove unused fields in struct mfld_mc_private Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).