From: Axel Lin <axel.lin@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: Liam Girdwood <lrg@ti.com>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
alsa-devel@alsa-project.org,
Peter Hsiang <peter.hsiang@maxim-ic.com>,
Jesse Marroquin <jesse.marroquin@maxim-ic.com>
Subject: [PATCH 1/2] ASoC: Add BUG() assertion if max98088_get_channel returns -EINVAL
Date: Wed, 28 Sep 2011 22:01:11 +0800 [thread overview]
Message-ID: <1317218471.8008.3.camel@phoenix> (raw)
The callers use the return value of max98088_get_channel as array index to
access max98088->dai[] array.
Add BUG() assertion for out of bound access of max98088->dai[] array.
Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
sound/soc/codecs/max98088.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/sound/soc/codecs/max98088.c b/sound/soc/codecs/max98088.c
index ac65a2d..aaca91c 100644
--- a/sound/soc/codecs/max98088.c
+++ b/sound/soc/codecs/max98088.c
@@ -1703,6 +1703,7 @@ static int max98088_get_channel(const char *name)
return 0;
if (strcmp(name, "EQ2 Mode") == 0)
return 1;
+ BUG();
return -EINVAL;
}
--
1.7.4.1
next reply other threads:[~2011-09-28 14:01 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-28 14:01 Axel Lin [this message]
2011-09-28 14:02 ` [PATCH 2/2] ASoC: Add BUG() assertion if max98095_get_bq_channel returns -EINVAL Axel Lin
2011-09-28 23:19 ` Ryan Mallon
2011-09-29 1:35 ` Dave Young
2011-09-29 1:52 ` Ryan Mallon
2011-09-29 1:59 ` Dave Young
2011-09-29 2:01 ` Ryan Mallon
2011-09-29 2:06 ` Dave Young
2011-09-29 1:33 ` Dave Young
2011-09-28 23:15 ` [PATCH 1/2] ASoC: Add BUG() assertion if max98088_get_channel " Ryan Mallon
2011-09-29 10:34 ` Mark Brown
2011-09-29 11:28 ` Ryan Mallon
2011-09-29 23:13 ` Ryan Mallon
2011-09-30 12:56 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1317218471.8008.3.camel@phoenix \
--to=axel.lin@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=jesse.marroquin@maxim-ic.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
--cc=peter.hsiang@maxim-ic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).