alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/2] ASoC: wm8400: Fix wrong bit setting for WM8400_POWER_MANAGEMENT_2
@ 2011-10-14  5:56 Axel Lin
  2011-10-14  5:57 ` [PATCH 2/2] ASoC: wm8990: Fix wrong bit setting for WM8990_POWER_MANAGEMENT_2 Axel Lin
  2011-10-14 19:36 ` [PATCH 1/2] ASoC: wm8400: Fix wrong bit setting for WM8400_POWER_MANAGEMENT_2 Mark Brown
  0 siblings, 2 replies; 3+ messages in thread
From: Axel Lin @ 2011-10-14  5:56 UTC (permalink / raw)
  To: linux-kernel; +Cc: Dimitris Papastamos, alsa-devel, Mark Brown, Liam Girdwood

If (fakepower & ((1 << WM8400_INMIXR_PWR) | (1 << WM8400_AINRMUX_PWR)))
is false, we should clear WM8400_AINR_ENA bits instead of WM8400_AINL_ENA.

Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
 sound/soc/codecs/wm8400.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/sound/soc/codecs/wm8400.c b/sound/soc/codecs/wm8400.c
index fbee556..dc13be2 100644
--- a/sound/soc/codecs/wm8400.c
+++ b/sound/soc/codecs/wm8400.c
@@ -383,7 +383,7 @@ static int inmixer_event (struct snd_soc_dapm_widget *w,
 		(1 << WM8400_AINRMUX_PWR))) {
 		reg |= WM8400_AINR_ENA;
 	} else {
-		reg &= ~WM8400_AINL_ENA;
+		reg &= ~WM8400_AINR_ENA;
 	}
 	wm8400_write(w->codec, WM8400_POWER_MANAGEMENT_2, reg);
 
-- 
1.7.4.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH 2/2] ASoC: wm8990: Fix wrong bit setting for WM8990_POWER_MANAGEMENT_2
  2011-10-14  5:56 [PATCH 1/2] ASoC: wm8400: Fix wrong bit setting for WM8400_POWER_MANAGEMENT_2 Axel Lin
@ 2011-10-14  5:57 ` Axel Lin
  2011-10-14 19:36 ` [PATCH 1/2] ASoC: wm8400: Fix wrong bit setting for WM8400_POWER_MANAGEMENT_2 Mark Brown
  1 sibling, 0 replies; 3+ messages in thread
From: Axel Lin @ 2011-10-14  5:57 UTC (permalink / raw)
  To: linux-kernel; +Cc: Mark Brown, Dimitris Papastamos, Liam Girdwood, alsa-devel

If (fakepower & ((1 << WM8990_INMIXR_PWR_BIT) | (1 << WM8990_AINRMUX_PWR_BIT)))
is false, we should clear WM8990_AINR_ENA bits instead of WM8990_AINL_ENA.

Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
 sound/soc/codecs/wm8990.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/sound/soc/codecs/wm8990.c b/sound/soc/codecs/wm8990.c
index ecdb8b2..b9c5ecc 100644
--- a/sound/soc/codecs/wm8990.c
+++ b/sound/soc/codecs/wm8990.c
@@ -401,7 +401,7 @@ static int inmixer_event(struct snd_soc_dapm_widget *w,
 		(1 << WM8990_AINRMUX_PWR_BIT))) {
 		reg |= WM8990_AINR_ENA;
 	} else {
-		reg &= ~WM8990_AINL_ENA;
+		reg &= ~WM8990_AINR_ENA;
 	}
 	snd_soc_write(w->codec, WM8990_POWER_MANAGEMENT_2, reg);
 
-- 
1.7.4.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/2] ASoC: wm8400: Fix wrong bit setting for WM8400_POWER_MANAGEMENT_2
  2011-10-14  5:56 [PATCH 1/2] ASoC: wm8400: Fix wrong bit setting for WM8400_POWER_MANAGEMENT_2 Axel Lin
  2011-10-14  5:57 ` [PATCH 2/2] ASoC: wm8990: Fix wrong bit setting for WM8990_POWER_MANAGEMENT_2 Axel Lin
@ 2011-10-14 19:36 ` Mark Brown
  1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2011-10-14 19:36 UTC (permalink / raw)
  To: Axel Lin; +Cc: linux-kernel, Dimitris Papastamos, Liam Girdwood, alsa-devel

On Fri, Oct 14, 2011 at 01:56:49PM +0800, Axel Lin wrote:
> If (fakepower & ((1 << WM8400_INMIXR_PWR) | (1 << WM8400_AINRMUX_PWR)))
> is false, we should clear WM8400_AINR_ENA bits instead of WM8400_AINL_ENA.
> 
> Signed-off-by: Axel Lin <axel.lin@gmail.com>

Applied both, thanks.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2011-10-14 19:36 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-10-14  5:56 [PATCH 1/2] ASoC: wm8400: Fix wrong bit setting for WM8400_POWER_MANAGEMENT_2 Axel Lin
2011-10-14  5:57 ` [PATCH 2/2] ASoC: wm8990: Fix wrong bit setting for WM8990_POWER_MANAGEMENT_2 Axel Lin
2011-10-14 19:36 ` [PATCH 1/2] ASoC: wm8400: Fix wrong bit setting for WM8400_POWER_MANAGEMENT_2 Mark Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).