alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Liam Girdwood <lrg@ti.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: alsa-devel@alsa-project.org, patches@opensource.wolfsonmicro.com
Subject: Re: [PATCH] ASoC: Convert WM9081 to table based control init
Date: Tue, 18 Oct 2011 08:49:13 +0100	[thread overview]
Message-ID: <1318924153.4001.2.camel@odin> (raw)
In-Reply-To: <1318892044-26609-1-git-send-email-broonie@opensource.wolfsonmicro.com>

On Mon, 2011-10-17 at 23:54 +0100, Mark Brown wrote:
> At least for the core controls, the optionally selected controls are still
> added programatically.
> 
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> ---
>  sound/soc/codecs/wm9081.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/sound/soc/codecs/wm9081.c b/sound/soc/codecs/wm9081.c
> index f4fc03b..93f794c 100644
> --- a/sound/soc/codecs/wm9081.c
> +++ b/sound/soc/codecs/wm9081.c
> @@ -1235,8 +1235,6 @@ static int wm9081_probe(struct snd_soc_codec *codec)
>  	snd_soc_update_bits(codec, WM9081_ANALOGUE_SPEAKER_PGA,
>  			    WM9081_SPKPGAZC, WM9081_SPKPGAZC);
>  
> -	snd_soc_add_controls(codec, wm9081_snd_controls,
> -			     ARRAY_SIZE(wm9081_snd_controls));
>  	if (!wm9081->pdata.num_retune_configs) {
>  		dev_dbg(codec->dev,
>  			"No ReTune Mobile data, using normal EQ\n");
> @@ -1296,6 +1294,8 @@ static struct snd_soc_codec_driver soc_codec_dev_wm9081 = {
>  	.reg_cache_default = wm9081_reg_defaults,
>  	.volatile_register = wm9081_volatile_register,
>  
> +	.controls         = wm9081_snd_controls,
> +	.num_controls     = ARRAY_SIZE(wm9081_snd_controls),
>  	.dapm_widgets	  = wm9081_dapm_widgets,
>  	.num_dapm_widgets = ARRAY_SIZE(wm9081_dapm_widgets),
>  	.dapm_routes     = wm9081_audio_paths,

Acked-by: Liam Girdwood <lrg@ti.com>

      reply	other threads:[~2011-10-18  7:49 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-17 22:54 [PATCH] ASoC: Convert WM9081 to table based control init Mark Brown
2011-10-18  7:49 ` Liam Girdwood [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1318924153.4001.2.camel@odin \
    --to=lrg@ti.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=patches@opensource.wolfsonmicro.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).