From: Ashish Chavan <ashish.chavan@kpitcummins.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: alsa-devel <alsa-devel@alsa-project.org>,
"kuninori.morimoto.gx" <kuninori.morimoto.gx@renesas.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
David@alsa-project.org, Chen <david.chen@diasemi.com>,
lrg <lrg@ti.com>
Subject: Re: [PATCH v3 2/8] ASoC: da7210: Add support for DAPM
Date: Wed, 19 Oct 2011 12:51:35 +0530 [thread overview]
Message-ID: <1319008895.7230.11.camel@matrix> (raw)
In-Reply-To: <20111017214107.GC5200@opensource.wolfsonmicro.com>
On Mon, 2011-10-17 at 22:41 +0100, Mark Brown wrote:
> On Sat, Oct 15, 2011 at 01:50:03PM +0530, Ashish Chavan wrote:
>
> > There are two type of registers for all IOs (HP, MIC, AUX) as well as
> > DAC and ADC. One type of registers control individual enable and disable
> > of IO, while other set of register controls the standby mode of that
> > particular IO. e.g. For ADC,
>
> What are "enable and disable" in this context? What do they do if not
> put the part of the chip into a low power mode? This is an intriguing
> hardware design and it really needs some documentation in the driver,
> right now it's just far too obscure and the driver looks buggy on code
> inspection.
>
I have queried hardware designers to get more insight in to this and
will update the response here. Probably after that we will be confident
about driver's handling of DAPM.
BTW if in case, hardware designers reiterate to use STANDBY registers,
will it suffice to only document this somewhere is the source?
next prev parent reply other threads:[~2011-10-19 7:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-14 11:01 [PATCH v3 2/8] ASoC: da7210: Add support for DAPM Ashish Chavan
2011-10-14 19:20 ` Mark Brown
2011-10-15 8:20 ` Ashish Chavan
2011-10-17 21:41 ` Mark Brown
2011-10-19 7:21 ` Ashish Chavan [this message]
2011-10-19 12:13 ` Mark Brown
2011-10-20 11:47 ` Ashish Chavan
2011-10-20 12:36 ` [alsa-devel] " Mark Brown
2011-10-20 13:49 ` Ashish Chavan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1319008895.7230.11.camel@matrix \
--to=ashish.chavan@kpitcummins.com \
--cc=David@alsa-project.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=david.chen@diasemi.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).