Re: [PATCH v7 2/3] ASoC: da7210: Add support for line out and DAC

[Ashish Chavan <ashish.chavan@kpitcummins.com>]

On Fri, 2011-10-21 at 10:00 +0100, Mark Brown wrote:
> On Fri, Oct 21, 2011 at 02:07:40PM +0530, Ashish Chavan wrote:
> > On Thu, 2011-10-20 at 18:10 +0100, Girdwood, Liam wrote:
> 
> > > Any reason for not using DAPM here ? Otherwise they are always on
> > > making your chip burn mW.....
> 
> > Not really. As explained in the comment in DAPM patch, this enables will
> > be effective (burn mW) only after respective IO is taken out from
> > STANDBY mode. DAPM takes care of managing STANDBY mode for all IOs and
> > ADC/DAC. I know this way of handling low power mode is bit non-trivial,
> > but it is what is recommended by chip designers. Actually Mark was also
> > initially confused with this and requested to put enough documentation
> > into code. After that I tried explaining the logic in source code
> > comment in DAPM patch. Let me know if it is not clear and doesn't convey
> > clearly what is should.
> 
> That'd be fine but there's no DAPM code in the patch, only code to
> unconditionally enable on init.
> 

Yes, because DAPM part for those IOs is already covered by DAPM patch.