From: Ashish Chavan <ashish.chavan@kpitcummins.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: alsa-devel <alsa-devel@alsa-project.org>,
"kuninori.morimoto.gx" <kuninori.morimoto.gx@renesas.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
David@alsa-project.org, Chen <david.chen@diasemi.com>,
lrg <lrg@ti.com>
Subject: Re: [PATCH v7 1/3] ASoC: da7210: Add support for DAPM
Date: Fri, 21 Oct 2011 16:07:21 +0530 [thread overview]
Message-ID: <1319193441.24621.170.camel@matrix> (raw)
In-Reply-To: <20111021085838.GE3513@opensource.wolfsonmicro.com>
On Fri, 2011-10-21 at 09:58 +0100, Mark Brown wrote:
> On Thu, Oct 20, 2011 at 07:32:49PM +0530, Ashish Chavan wrote:
> > This patch adds support for DAPM covering all inputs and outputs
> > as well as ADC and DAC.
>
> This patch doesn't apply against current code.
Some how I am unable to sync my tree right now. BTW I re-tested it and
it applies fine on my tree. I am assuming that your tree has my earlier
patches for mute controls and ALC applied.
Is there web interface to your tree? so that I can introspect your
version of da7210.c file to find out what is going wrong? Or any other
way to get your version of that file?
>
> > +/*
> > + * DAPM Controls
> > + *
> > + * Current DAPM implementation covers almost all codec components e.g. IOs,
> > + * mixers, PGAs,ADC and DAC.
>
> This explanation would better placed next to the code in the probe -
> it's that code which looks out of place in a Linux driver.
>
next prev parent reply other threads:[~2011-10-21 10:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-20 14:02 [PATCH v7 1/3] ASoC: da7210: Add support for DAPM Ashish Chavan
2011-10-20 16:58 ` [alsa-devel] " Girdwood, Liam
2011-10-21 8:58 ` Mark Brown
2011-10-21 9:47 ` Ashish Chavan
2011-10-21 10:23 ` Mark Brown
2011-10-21 10:37 ` Ashish Chavan [this message]
2011-10-21 10:31 ` Mark Brown
2011-10-21 11:01 ` Ashish Chavan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1319193441.24621.170.camel@matrix \
--to=ashish.chavan@kpitcummins.com \
--cc=David@alsa-project.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=david.chen@diasemi.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox