alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Daniel Mack <zonque@gmail.com>
To: alsa-devel@alsa-project.org
Cc: gdiffey@gmail.com, tiwai@suse.de, clemens@ladisch.de,
	linuxaudio@showlabor.de, Daniel Mack <zonque@gmail.com>,
	blablack@gmail.com
Subject: [PATCH 5/5] ALSA: snd-usb: add support for implicit feedback
Date: Mon, 31 Oct 2011 13:10:30 +0100	[thread overview]
Message-ID: <1320063030-3502-6-git-send-email-zonque@gmail.com> (raw)
In-Reply-To: <1320063030-3502-1-git-send-email-zonque@gmail.com>

---
 sound/usb/pcm.c |   14 ++++++++++----
 1 files changed, 10 insertions(+), 4 deletions(-)

diff --git a/sound/usb/pcm.c b/sound/usb/pcm.c
index af21d38..e88abfa 100644
--- a/sound/usb/pcm.c
+++ b/sound/usb/pcm.c
@@ -312,9 +312,12 @@ static int set_format(struct snd_usb_substream *subs, struct audioformat *fmt)
 	if (((is_playback && attr == USB_ENDPOINT_SYNC_ASYNC) ||
 	     (! is_playback && attr == USB_ENDPOINT_SYNC_ADAPTIVE)) &&
 	    altsd->bNumEndpoints >= 2) {
+		int implicit_fb = (get_endpoint(alts, 1)->bmAttributes & USB_ENDPOINT_USAGE_MASK)
+				== USB_ENDPOINT_USAGE_IMPLICIT_FB;
 		switch (subs->stream->chip->usb_id) {
 		case USB_ID(0x0763, 0x2080): /* M-Audio FastTrack Ultra */
 		case USB_ID(0x0763, 0x2081):
+			implicit_fb = 1;
 			ep = 0x81;
 			iface = usb_ifnum_to_if(dev, 2);
 			alts = &iface->altsetting[1];
@@ -327,7 +330,8 @@ static int set_format(struct snd_usb_substream *subs, struct audioformat *fmt)
 		   the audio fields in the endpoint descriptors */
 		if ((get_endpoint(alts, 1)->bmAttributes & USB_ENDPOINT_XFERTYPE_MASK) != 0x01 ||
 		    (get_endpoint(alts, 1)->bLength >= USB_DT_ENDPOINT_AUDIO_SIZE &&
-		     get_endpoint(alts, 1)->bSynchAddress != 0)) {
+		     get_endpoint(alts, 1)->bSynchAddress != 0 &&
+		     !implicit_fb)) {
 			snd_printk(KERN_ERR "%d:%d:%d : invalid synch pipe\n",
 				   dev->devnum, fmt->iface, fmt->altsetting);
 			return -EINVAL;
@@ -335,7 +339,8 @@ static int set_format(struct snd_usb_substream *subs, struct audioformat *fmt)
 		ep = get_endpoint(alts, 1)->bEndpointAddress;
 		if (get_endpoint(alts, 0)->bLength >= USB_DT_ENDPOINT_AUDIO_SIZE &&
 		    (( is_playback && ep != (unsigned int)(get_endpoint(alts, 0)->bSynchAddress | USB_DIR_IN)) ||
-		     (!is_playback && ep != (unsigned int)(get_endpoint(alts, 0)->bSynchAddress & ~USB_DIR_IN)))) {
+		     (!is_playback && ep != (unsigned int)(get_endpoint(alts, 0)->bSynchAddress & ~USB_DIR_IN)) ||
+		     ( is_playback && !implicit_fb))) {
 			snd_printk(KERN_ERR "%d:%d:%d : invalid synch pipe\n",
 				   dev->devnum, fmt->iface, fmt->altsetting);
 			return -EINVAL;
@@ -343,8 +348,9 @@ static int set_format(struct snd_usb_substream *subs, struct audioformat *fmt)
 add_sync_ep:
 		subs->sync_endpoint = snd_usb_add_endpoint(subs->stream->chip,
 							   alts, ep, !subs->direction,
-							   SND_USB_ENDPOINT_TYPE_SYNC);
-
+							   implicit_fb ?
+								SND_USB_ENDPOINT_TYPE_DATA :
+								SND_USB_ENDPOINT_TYPE_SYNC);
 		if (!subs->sync_endpoint)
 			return -EINVAL;
 
-- 
1.7.5.4

  parent reply	other threads:[~2011-10-31 12:10 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-31 12:10 [PATCH 0/5] RFC for snd-usb: rework usb endpoint logic Daniel Mack
2011-10-31 12:10 ` [PATCH 1/5] ALSA: snd-usb: implement new endpoint streaming model Daniel Mack
2011-11-01 20:57   ` Clemens Ladisch
2011-11-02  8:36     ` Daniel Mack
2011-11-02 10:26   ` Clemens Ladisch
2011-11-02 14:29     ` Daniel Mack
2011-11-02 15:49       ` Clemens Ladisch
2011-11-03 15:21         ` Daniel Mack
2011-11-03 16:42           ` Clemens Ladisch
2011-10-31 12:10 ` [PATCH 2/5] ALSA: snd-usb: switch over to new endpoint streaming logic Daniel Mack
2011-11-01 20:57   ` Clemens Ladisch
2011-11-02 15:58     ` Takashi Iwai
2011-11-02 16:18       ` Clemens Ladisch
2011-11-02 16:18         ` Takashi Iwai
2011-11-02 22:01       ` Torsten Schenk
2011-11-18 14:44         ` Daniel Mack
2011-11-18 14:41     ` Daniel Mack
2011-10-31 12:10 ` [PATCH 3/5] ALSA: snd-usb: remove old " Daniel Mack
2011-10-31 12:10 ` [PATCH 4/5] ALSA: snd-usb: set MAX_URBS to 16 Daniel Mack
2011-11-01 20:57   ` Clemens Ladisch
2011-10-31 12:10 ` Daniel Mack [this message]
2011-10-31 12:38 ` [PATCH 0/5] RFC for snd-usb: rework usb endpoint logic Daniel Mack
2011-11-01  8:50   ` Aurélien Leblond
2011-11-01  9:15     ` Daniel Mack
2011-11-01  9:40       ` Felix Homann
2011-11-01 10:25         ` Daniel Mack
2011-11-01 10:39           ` Felix Homann
2011-11-01 12:11             ` Daniel Mack
2011-11-01 13:59               ` Grant Diffey
2011-11-01 15:36               ` Takashi Iwai
2011-11-01 16:19   ` Takashi Iwai
2011-11-01 19:03     ` Felix Homann
2011-11-02  6:49       ` Takashi Iwai
2011-11-02  8:27     ` Daniel Mack
  -- strict thread matches above, loose matches on Subject: below --
2011-11-18 20:05 [PATCH 0/5] RFC v2 for snd-usb endpoint logic rework Daniel Mack
2011-11-18 20:05 ` [PATCH 5/5] ALSA: snd-usb: add support for implicit feedback Daniel Mack
2011-11-18 20:22   ` Daniel Mack
2011-12-18 23:02 [PATCH 0/5] snd-usb endpoint logic rework, version 3 Daniel Mack
2011-12-18 23:02 ` [PATCH 5/5] ALSA: snd-usb: add support for implicit feedback Daniel Mack
2011-12-20  9:48 [PATCH 0/5] snd-usb endpoint rework, take 4 Daniel Mack
2011-12-20  9:48 ` [PATCH 5/5] ALSA: snd-usb: add support for implicit feedback Daniel Mack
2011-12-20 23:34 [PATCH 0/5] snd-usb endpoint rework, take 5 Daniel Mack
2011-12-20 23:34 ` [PATCH 5/5] ALSA: snd-usb: add support for implicit feedback Daniel Mack

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1320063030-3502-6-git-send-email-zonque@gmail.com \
    --to=zonque@gmail.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=blablack@gmail.com \
    --cc=clemens@ladisch.de \
    --cc=gdiffey@gmail.com \
    --cc=linuxaudio@showlabor.de \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).