* [PATCH] Revert "ASoC: Fix build dependency for SND_ATMEL_SOC_SSC"
@ 2012-01-09 3:29 Axel Lin
2012-01-09 4:15 ` Mark Brown
0 siblings, 1 reply; 5+ messages in thread
From: Axel Lin @ 2012-01-09 3:29 UTC (permalink / raw)
To: alsa-devel; +Cc: Stephen Rothwell, Paul Bolle, Mark Brown, Liam Girdwood
This reverts commit 739be96ab83755e10fd0c2b6a34c8a73254527f7 because it
introduces below build warnings:
drivers/misc/Kconfig:212:error: recursive dependency detected!
drivers/misc/Kconfig:212: symbol ATMEL_SSC is selected by SND_ATMEL_SOC_SSC
sound/soc/atmel/Kconfig:9: symbol SND_ATMEL_SOC_SSC is selected by SND_AT91_SOC_SAM9G20_WM8731
sound/soc/atmel/Kconfig:18: symbol SND_AT91_SOC_SAM9G20_WM8731 depends on ATMEL_SSC
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
sound/soc/atmel/Kconfig | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/sound/soc/atmel/Kconfig b/sound/soc/atmel/Kconfig
index a4d6742..d1fcc81 100644
--- a/sound/soc/atmel/Kconfig
+++ b/sound/soc/atmel/Kconfig
@@ -9,7 +9,6 @@ config SND_ATMEL_SOC
config SND_ATMEL_SOC_SSC
tristate
depends on SND_ATMEL_SOC
- select ATMEL_SSC
help
Say Y or M if you want to add support for codecs the
ATMEL SSC interface. You will also needs to select the individual
--
1.7.5.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] Revert "ASoC: Fix build dependency for SND_ATMEL_SOC_SSC"
2012-01-09 3:29 [PATCH] Revert "ASoC: Fix build dependency for SND_ATMEL_SOC_SSC" Axel Lin
@ 2012-01-09 4:15 ` Mark Brown
2012-01-09 4:40 ` Axel Lin
0 siblings, 1 reply; 5+ messages in thread
From: Mark Brown @ 2012-01-09 4:15 UTC (permalink / raw)
To: Axel Lin; +Cc: Stephen Rothwell, alsa-devel, Paul Bolle, Liam Girdwood
On Mon, Jan 09, 2012 at 11:29:43AM +0800, Axel Lin wrote:
> This reverts commit 739be96ab83755e10fd0c2b6a34c8a73254527f7 because it
> introduces below build warnings:
> drivers/misc/Kconfig:212: symbol ATMEL_SSC is selected by SND_ATMEL_SOC_SSC
> sound/soc/atmel/Kconfig:9: symbol SND_ATMEL_SOC_SSC is selected by SND_AT91_SOC_SAM9G20_WM8731
> sound/soc/atmel/Kconfig:18: symbol SND_AT91_SOC_SAM9G20_WM8731 depends on ATMEL_SSC
> config SND_ATMEL_SOC_SSC
> tristate
> depends on SND_ATMEL_SOC
> - select ATMEL_SSC
Why is this the best fix? It's not obvious to me that the dependency
from the machine driver to the ATMEL_SSC (rather than a select or
relying on the SSC driver sorting things out) is correct.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Revert "ASoC: Fix build dependency for SND_ATMEL_SOC_SSC"
2012-01-09 4:15 ` Mark Brown
@ 2012-01-09 4:40 ` Axel Lin
2012-01-09 6:23 ` Mark Brown
0 siblings, 1 reply; 5+ messages in thread
From: Axel Lin @ 2012-01-09 4:40 UTC (permalink / raw)
To: Mark Brown; +Cc: Stephen Rothwell, alsa-devel, Paul Bolle, Liam Girdwood
2012/1/9 Mark Brown <broonie@opensource.wolfsonmicro.com>:
> On Mon, Jan 09, 2012 at 11:29:43AM +0800, Axel Lin wrote:
>> This reverts commit 739be96ab83755e10fd0c2b6a34c8a73254527f7 because it
>> introduces below build warnings:
>
>> drivers/misc/Kconfig:212: symbol ATMEL_SSC is selected by SND_ATMEL_SOC_SSC
>> sound/soc/atmel/Kconfig:9: symbol SND_ATMEL_SOC_SSC is selected by SND_AT91_SOC_SAM9G20_WM8731
>> sound/soc/atmel/Kconfig:18: symbol SND_AT91_SOC_SAM9G20_WM8731 depends on ATMEL_SSC
>
>> config SND_ATMEL_SOC_SSC
>> tristate
>> depends on SND_ATMEL_SOC
>> - select ATMEL_SSC
>
> Why is this the best fix? It's not obvious to me that the dependency
> from the machine driver to the ATMEL_SSC (rather than a select or
> relying on the SSC driver sorting things out) is correct.
The issue is that SND_ATMEL_SOC_SSC needs ATMEL_SSC to pass compilation.
We now got the build warnings as Stephen points out.
So I revert the patch.
Both SND_AT91_SOC_SAM9G20_WM8731 and SND_AT91_SOC_AFEB9260 selects
SND_ATMEL_SOC_SSC.
Thus we need to make both machine drivers depend on ATMEL_SSC.
I think this patch reverts the problematic patch.
And then you can apply [PATCH] ASoC: Fix build dependency for
SND_AT91_SOC_AFEB9260 (
http://mailman.alsa-project.org/pipermail/alsa-devel/2012-January/047861.html
)
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Revert "ASoC: Fix build dependency for SND_ATMEL_SOC_SSC"
2012-01-09 4:40 ` Axel Lin
@ 2012-01-09 6:23 ` Mark Brown
2012-01-09 9:38 ` Axel Lin
0 siblings, 1 reply; 5+ messages in thread
From: Mark Brown @ 2012-01-09 6:23 UTC (permalink / raw)
To: Axel Lin; +Cc: Stephen Rothwell, alsa-devel, Paul Bolle, Liam Girdwood
On Mon, Jan 09, 2012 at 12:40:35PM +0800, Axel Lin wrote:
> I think this patch reverts the problematic patch.
> And then you can apply [PATCH] ASoC: Fix build dependency for
> SND_AT91_SOC_AFEB9260 (
> http://mailman.alsa-project.org/pipermail/alsa-devel/2012-January/047861.html
> )
What I asked for here was a patch which brings the tree to the desired
state. Clearly I can just run git revert myself if I want to...
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Revert "ASoC: Fix build dependency for SND_ATMEL_SOC_SSC"
2012-01-09 6:23 ` Mark Brown
@ 2012-01-09 9:38 ` Axel Lin
0 siblings, 0 replies; 5+ messages in thread
From: Axel Lin @ 2012-01-09 9:38 UTC (permalink / raw)
To: Mark Brown; +Cc: Stephen Rothwell, alsa-devel, Paul Bolle, Liam Girdwood
2012/1/9 Mark Brown <broonie@opensource.wolfsonmicro.com>:
> On Mon, Jan 09, 2012 at 12:40:35PM +0800, Axel Lin wrote:
>
>> I think this patch reverts the problematic patch.
>> And then you can apply [PATCH] ASoC: Fix build dependency for
>> SND_AT91_SOC_AFEB9260 (
>> http://mailman.alsa-project.org/pipermail/alsa-devel/2012-January/047861.html
>> )
>
> What I asked for here was a patch which brings the tree to the desired
> state. Clearly I can just run git revert myself if I want to...
I misunderstand what you mean.
Now a new patch is on the way.
Thanks,
Axel
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2012-01-09 9:39 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-01-09 3:29 [PATCH] Revert "ASoC: Fix build dependency for SND_ATMEL_SOC_SSC" Axel Lin
2012-01-09 4:15 ` Mark Brown
2012-01-09 4:40 ` Axel Lin
2012-01-09 6:23 ` Mark Brown
2012-01-09 9:38 ` Axel Lin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).