[PATCH] ASoC: Fix idma build after update for channel count check

[PATCH] ASoC: Fix idma build after update for channel count check

[Mark Brown]

Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
---
 sound/soc/samsung/idma.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/sound/soc/samsung/idma.c b/sound/soc/samsung/idma.c
index 3ba6aba..c227c31 100644
--- a/sound/soc/samsung/idma.c
+++ b/sound/soc/samsung/idma.c
@@ -398,6 +398,7 @@ static int idma_new(struct snd_soc_pcm_runtime *rtd)
 	if (pcm->streams[SNDRV_PCM_STREAM_PLAYBACK].substream) {
 		ret = preallocate_idma_buffer(pcm,
 				SNDRV_PCM_STREAM_PLAYBACK);
+	}
 
 	return ret;
 }
-- 
1.7.7.3

Re: [PATCH] ASoC: Fix idma build after update for channel count check

[Joachim Eastwood]

Hi Mark,

On Mon, Jan 9, 2012 at 7:53 AM, Mark Brown
<broonie@opensource.wolfsonmicro.com> wrote:
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> ---
>  sound/soc/samsung/idma.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/sound/soc/samsung/idma.c b/sound/soc/samsung/idma.c
> index 3ba6aba..c227c31 100644
> --- a/sound/soc/samsung/idma.c
> +++ b/sound/soc/samsung/idma.c
> @@ -398,6 +398,7 @@ static int idma_new(struct snd_soc_pcm_runtime *rtd)
>        if (pcm->streams[SNDRV_PCM_STREAM_PLAYBACK].substream) {
>                ret = preallocate_idma_buffer(pcm,
>                                SNDRV_PCM_STREAM_PLAYBACK);
> +       }
>
>        return ret;
>  }
> --

I accidentally added the brace to the if test in "ASoC: check for
substream not channels_min in pcm engines".
So you either remove the brace from the if test or add another one as you did.

Acked-by: Joachim Eastwood <joachim.eastwood@jotron.com>

regards
Joachim Eastwood

> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

Re: [PATCH] ASoC: Fix idma build after update for channel count check

[Sangbeom Kim]

Hi Joachim,

On Mon, Jan 9, 2012 at 4:08 PM, Joachim Eastwood wrote:
> I accidentally added the brace to the if test in "ASoC: check for
> substream not channels_min in pcm engines".
> So you either remove the brace from the if test or add another one as you
> did.
> 
> Acked-by: Joachim Eastwood <joachim.eastwood@jotron.com>
> 

Thanks for your care to ASoC Samsung code.
If you change ASoC Samsung code, Could you please include me in the CC list?

Acked-by: Sangbeom Kim <sbkim73@samsung.com>

Thanks,
Sangbeom.