* [PATCH] ASoC: core - Improve card registration error messaging for large DAI links.
@ 2012-01-09 12:09 Liam Girdwood
2012-01-09 22:23 ` Mark Brown
0 siblings, 1 reply; 2+ messages in thread
From: Liam Girdwood @ 2012-01-09 12:09 UTC (permalink / raw)
To: Mark Brown; +Cc: alsa-devel, Liam Girdwood
Print out the offending DAI link entry when a naming error occurs. Makes
thing easier to debug for machines with a large number of DAI links.
Signed-off-by: Liam Girdwood <lrg@ti.com>
---
sound/soc/soc-core.c | 8 +++++---
1 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c
index acbb960..e1d8433 100644
--- a/sound/soc/soc-core.c
+++ b/sound/soc/soc-core.c
@@ -2854,7 +2854,8 @@ int snd_soc_register_card(struct snd_soc_card *card)
*/
if (!!link->codec_name == !!link->codec_of_node) {
dev_err(card->dev,
- "Neither/both codec name/of_node are set\n");
+ "Neither/both codec name/of_node are set for %s\n",
+ link->name);
return -EINVAL;
}
@@ -2864,7 +2865,7 @@ int snd_soc_register_card(struct snd_soc_card *card)
*/
if (link->platform_name && link->platform_of_node) {
dev_err(card->dev,
- "Both platform name/of_node are set\n");
+ "Both platform name/of_node are set for %s\n", link->name);
return -EINVAL;
}
@@ -2874,7 +2875,8 @@ int snd_soc_register_card(struct snd_soc_card *card)
*/
if (!!link->cpu_dai_name == !!link->cpu_dai_of_node) {
dev_err(card->dev,
- "Neither/both cpu_dai name/of_node are set\n");
+ "Neither/both cpu_dai name/of_node are set for %s\n",
+ link->name);
return -EINVAL;
}
}
--
1.7.5.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ASoC: core - Improve card registration error messaging for large DAI links.
2012-01-09 12:09 [PATCH] ASoC: core - Improve card registration error messaging for large DAI links Liam Girdwood
@ 2012-01-09 22:23 ` Mark Brown
0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2012-01-09 22:23 UTC (permalink / raw)
To: Liam Girdwood; +Cc: alsa-devel
On Mon, Jan 09, 2012 at 12:09:29PM +0000, Liam Girdwood wrote:
> Print out the offending DAI link entry when a naming error occurs. Makes
> thing easier to debug for machines with a large number of DAI links.
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-01-09 22:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-01-09 12:09 [PATCH] ASoC: core - Improve card registration error messaging for large DAI links Liam Girdwood
2012-01-09 22:23 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).