Re: [PATCH] ASoC: twl6040 - Add method to query optimum PDM_DL1 gain

[Liam Girdwood <lrg@ti.com>]

On Tue, 2012-01-10 at 19:29 +0000, Mark Brown wrote:
> On Tue, Jan 10, 2012 at 11:03:09AM +0000, Liam Girdwood wrote:
> > On Tue, 2012-01-10 at 00:44 +0000, Mark Brown wrote:
> > > On Mon, Jan 09, 2012 at 12:11:22PM +0000, Liam Girdwood wrote:
> 
> > > > The DL1 PDM interface adds a little gain depending on the output device.
> > > > Add a method to retrieve the gain value for machine driver usage.
> 
> > > I'm having a hard time understanding how the machine driver would use
> > > this information...
> 
> > It's intended that the machine driver would use this information to
> > configure the ABE to compensate any attenuation so that the output
> > volume level was constant.
> 
> So if you turn on some of the outputs in the CODEC the CODEC will apply
> a gain to the signal coming in on DL1 which affects other CODEC outputs
> and this needs to be worked around in the ABE so the machine driver is
> doing that?

Yes, but the Codec component (widget) must also be enabled for the
attenuation to happen.

> 
> > > > +int twl6040_get_dl1_gain(struct snd_soc_codec *codec)
> > > > +{
> > > > +	struct snd_soc_dapm_context *dapm = &codec->dapm;
> > > > +
> > > > +	if (snd_soc_dapm_get_pin_status(dapm, "EP"))
> > > > +		return -1; /* -1dB */
> 
> > > Shouldn't this be being done by reading the CODEC register settings to
> > > know which output DL1 is connected to?
> 
> > The DL1 path output devices can all operate at the same time and may or
> > may not be connected by the machine drivers.
> 
> But surely the paths from DL1 to the various outputs within the CODEC
> are controlled by registers in the CODEC?  I don't understand why the
> CODEC needs to query DAPM here.

The machine driver may not have the Earpiece, Handsfree or Headset
connected (even though the codec path is set to use them). The codec has
no way of knowing this except to check the widget DAPM status for the
outputs. Now we can check the DAPM status of each widget by reading the
codec register, but I think that defeats DAPMs codec widget power
control and status APIs.

I've applied this since I'm doing pull request this morning, you are in
Asia and this is a trivial patch. We can rework if required later.

Liam