* [PATCH] Alsa-utils: Fix typo causing some volumes not to be initialized
@ 2012-01-11 16:45 David Henningsson
2012-01-13 9:05 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: David Henningsson @ 2012-01-11 16:45 UTC (permalink / raw)
To: tiwai, alsa-devel; +Cc: David Henningsson
When I was reading the source code, I stumbled over this typo causing
Center, LFE, and Surround speakers not to be initialized.
Signed-off-by: David Henningsson <david.henningsson@canonical.com>
---
alsactl/init/default | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/alsactl/init/default b/alsactl/init/default
index af64cb1..5fb0113 100644
--- a/alsactl/init/default
+++ b/alsactl/init/default
@@ -124,7 +124,7 @@ CTL{name}="Front Speaker Playback Switch",CTL{do_search}=="1", \
CTL{values}="on"
CTL{reset}="mixer"
-CTL{name}="Front Speaker Playback Volume",PROGRAM!="__ctl_search",GOTO=""
+CTL{name}="Surround Speaker Playback Volume",PROGRAM!="__ctl_search",GOTO=""
# if master volume control is present, turn speaker volume to max
ENV{has_pmaster_vol}=="true",CTL{write}=="0dB",GOTO=""
ENV{has_pmaster_vol}=="true",CTL{write}=="100%",GOTO=""
@@ -134,7 +134,7 @@ CTL{name}="Surround Speaker Playback Switch",CTL{do_search}=="1", \
CTL{values}="on"
CTL{reset}="mixer"
-CTL{name}="Front Speaker Playback Volume",PROGRAM!="__ctl_search",GOTO=""
+CTL{name}="Center Speaker Playback Volume",PROGRAM!="__ctl_search",GOTO=""
# if master volume control is present, turn speaker volume to max
ENV{has_pmaster_vol}=="true",CTL{write}=="0dB",GOTO=""
ENV{has_pmaster_vol}=="true",CTL{write}=="100%",GOTO=""
@@ -144,7 +144,7 @@ CTL{name}="Center Speaker Playback Switch",CTL{do_search}=="1", \
CTL{values}="on"
CTL{reset}="mixer"
-CTL{name}="Front Speaker Playback Volume",PROGRAM!="__ctl_search",GOTO=""
+CTL{name}="LFE Speaker Playback Volume",PROGRAM!="__ctl_search",GOTO=""
# if master volume control is present, turn speaker volume to max
ENV{has_pmaster_vol}=="true",CTL{write}=="0dB",GOTO=""
ENV{has_pmaster_vol}=="true",CTL{write}=="100%",GOTO=""
--
1.7.5.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Alsa-utils: Fix typo causing some volumes not to be initialized
2012-01-11 16:45 [PATCH] Alsa-utils: Fix typo causing some volumes not to be initialized David Henningsson
@ 2012-01-13 9:05 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2012-01-13 9:05 UTC (permalink / raw)
To: David Henningsson; +Cc: alsa-devel
At Wed, 11 Jan 2012 17:45:14 +0100,
David Henningsson wrote:
>
> When I was reading the source code, I stumbled over this typo causing
> Center, LFE, and Surround speakers not to be initialized.
>
> Signed-off-by: David Henningsson <david.henningsson@canonical.com>
Applied now. Thanks.
Takashi
> ---
> alsactl/init/default | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/alsactl/init/default b/alsactl/init/default
> index af64cb1..5fb0113 100644
> --- a/alsactl/init/default
> +++ b/alsactl/init/default
> @@ -124,7 +124,7 @@ CTL{name}="Front Speaker Playback Switch",CTL{do_search}=="1", \
> CTL{values}="on"
>
> CTL{reset}="mixer"
> -CTL{name}="Front Speaker Playback Volume",PROGRAM!="__ctl_search",GOTO=""
> +CTL{name}="Surround Speaker Playback Volume",PROGRAM!="__ctl_search",GOTO=""
> # if master volume control is present, turn speaker volume to max
> ENV{has_pmaster_vol}=="true",CTL{write}=="0dB",GOTO=""
> ENV{has_pmaster_vol}=="true",CTL{write}=="100%",GOTO=""
> @@ -134,7 +134,7 @@ CTL{name}="Surround Speaker Playback Switch",CTL{do_search}=="1", \
> CTL{values}="on"
>
> CTL{reset}="mixer"
> -CTL{name}="Front Speaker Playback Volume",PROGRAM!="__ctl_search",GOTO=""
> +CTL{name}="Center Speaker Playback Volume",PROGRAM!="__ctl_search",GOTO=""
> # if master volume control is present, turn speaker volume to max
> ENV{has_pmaster_vol}=="true",CTL{write}=="0dB",GOTO=""
> ENV{has_pmaster_vol}=="true",CTL{write}=="100%",GOTO=""
> @@ -144,7 +144,7 @@ CTL{name}="Center Speaker Playback Switch",CTL{do_search}=="1", \
> CTL{values}="on"
>
> CTL{reset}="mixer"
> -CTL{name}="Front Speaker Playback Volume",PROGRAM!="__ctl_search",GOTO=""
> +CTL{name}="LFE Speaker Playback Volume",PROGRAM!="__ctl_search",GOTO=""
> # if master volume control is present, turn speaker volume to max
> ENV{has_pmaster_vol}=="true",CTL{write}=="0dB",GOTO=""
> ENV{has_pmaster_vol}=="true",CTL{write}=="100%",GOTO=""
> --
> 1.7.5.4
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-01-13 9:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-01-11 16:45 [PATCH] Alsa-utils: Fix typo causing some volumes not to be initialized David Henningsson
2012-01-13 9:05 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).