alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>,
	Liam Girdwood <lrg@ti.com>
Cc: alsa-devel@alsa-project.org
Subject: [PATCH v3 2/7] ASoC: Apply msbits constraint for sample size bigger than the msbits
Date: Wed, 18 Jan 2012 10:51:03 +0100	[thread overview]
Message-ID: <1326880268-3509-3-git-send-email-peter.ujfalusi@ti.com> (raw)
In-Reply-To: <1326880268-3509-1-git-send-email-peter.ujfalusi@ti.com>

In order to avoid confusing the applications with msbits bigger
than the selected sample size apply the msbits constraint only
to sample seze bigger than the requested msbits.

Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
---
 sound/soc/soc-pcm.c |    7 +++++--
 1 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/sound/soc/soc-pcm.c b/sound/soc/soc-pcm.c
index 8bb1793..e150ede 100644
--- a/sound/soc/soc-pcm.c
+++ b/sound/soc/soc-pcm.c
@@ -68,13 +68,14 @@ static int soc_pcm_apply_symmetry(struct snd_pcm_substream *substream,
  * like the DAC/ADC resolution to use but there isn't right now.
  */
 static int sample_sizes[] = {
-	8, 16, 24, 32,
+	32, 24, 16, 8,
 };
 
 static void soc_pcm_apply_msb(struct snd_pcm_substream *substream,
 			      struct snd_soc_dai *dai)
 {
-	int ret, i, bits;
+	int i, bits;
+	int ret = 0;
 
 	if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK)
 		bits = dai->driver->playback.sig_bits;
@@ -85,6 +86,8 @@ static void soc_pcm_apply_msb(struct snd_pcm_substream *substream,
 		return;
 
 	for (i = 0; i < ARRAY_SIZE(sample_sizes); i++) {
+		if (sample_sizes[i] <= bits)
+			break;
 		ret = snd_pcm_hw_constraint_msbits(substream->runtime,
 						   0, sample_sizes[i],
 						   bits);
-- 
1.7.8.3

  parent reply	other threads:[~2012-01-18  9:51 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-18  9:51 [PATCH v3 0/7] ASoC: Add support in core to set msbits constraint Peter Ujfalusi
2012-01-18  9:51 ` [PATCH v3 1/7] ASoC: Allow drivers to specify how many bits are significant on a DAI Peter Ujfalusi
2012-01-18 10:41   ` Mark Brown
2012-01-18  9:51 ` Peter Ujfalusi [this message]
2012-01-18  9:51 ` [PATCH v3 3/7] ASoC: 24 bits are significant on the WM8996 audio interfaces Peter Ujfalusi
2012-01-18  9:51 ` [PATCH v3 4/7] ASoC: omap-dmic: Use core to set the msbits constraint Peter Ujfalusi
2012-01-18  9:51 ` [PATCH v3 5/7] ASoC: omap-mcpdm: Set 24msbits constraint Peter Ujfalusi
2012-01-18  9:51 ` [PATCH v3 6/7] ASoC: tlv320dac33: Use core to set the msbits constraint Peter Ujfalusi
2012-01-18  9:51 ` [PATCH v3 7/7] ASoC: twl4030: " Peter Ujfalusi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1326880268-3509-3-git-send-email-peter.ujfalusi@ti.com \
    --to=peter.ujfalusi@ti.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=lrg@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).