From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>,
Liam Girdwood <lrg@ti.com>
Cc: alsa-devel@alsa-project.org
Subject: [PATCH v3 4/7] ASoC: omap-dmic: Use core to set the msbits constraint
Date: Wed, 18 Jan 2012 10:51:05 +0100 [thread overview]
Message-ID: <1326880268-3509-5-git-send-email-peter.ujfalusi@ti.com> (raw)
In-Reply-To: <1326880268-3509-1-git-send-email-peter.ujfalusi@ti.com>
Core can set the msbits constraint in behalf of the dai.
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
---
sound/soc/omap/omap-dmic.c | 7 +++----
1 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/sound/soc/omap/omap-dmic.c b/sound/soc/omap/omap-dmic.c
index 0855c1c..4dcb5a7 100644
--- a/sound/soc/omap/omap-dmic.c
+++ b/sound/soc/omap/omap-dmic.c
@@ -113,12 +113,10 @@ static int omap_dmic_dai_startup(struct snd_pcm_substream *substream,
mutex_lock(&dmic->mutex);
- if (!dai->active) {
- snd_pcm_hw_constraint_msbits(substream->runtime, 0, 32, 24);
+ if (!dai->active)
dmic->active = 1;
- } else {
+ else
ret = -EBUSY;
- }
mutex_unlock(&dmic->mutex);
@@ -445,6 +443,7 @@ static struct snd_soc_dai_driver omap_dmic_dai = {
.channels_max = 6,
.rates = SNDRV_PCM_RATE_96000 | SNDRV_PCM_RATE_192000,
.formats = SNDRV_PCM_FMTBIT_S32_LE,
+ .sig_bits = 24,
},
.ops = &omap_dmic_dai_ops,
};
--
1.7.8.3
next prev parent reply other threads:[~2012-01-18 9:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-18 9:51 [PATCH v3 0/7] ASoC: Add support in core to set msbits constraint Peter Ujfalusi
2012-01-18 9:51 ` [PATCH v3 1/7] ASoC: Allow drivers to specify how many bits are significant on a DAI Peter Ujfalusi
2012-01-18 10:41 ` Mark Brown
2012-01-18 9:51 ` [PATCH v3 2/7] ASoC: Apply msbits constraint for sample size bigger than the msbits Peter Ujfalusi
2012-01-18 9:51 ` [PATCH v3 3/7] ASoC: 24 bits are significant on the WM8996 audio interfaces Peter Ujfalusi
2012-01-18 9:51 ` Peter Ujfalusi [this message]
2012-01-18 9:51 ` [PATCH v3 5/7] ASoC: omap-mcpdm: Set 24msbits constraint Peter Ujfalusi
2012-01-18 9:51 ` [PATCH v3 6/7] ASoC: tlv320dac33: Use core to set the msbits constraint Peter Ujfalusi
2012-01-18 9:51 ` [PATCH v3 7/7] ASoC: twl4030: " Peter Ujfalusi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1326880268-3509-5-git-send-email-peter.ujfalusi@ti.com \
--to=peter.ujfalusi@ti.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=lrg@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).