From: Liam Girdwood <lrg@ti.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: alsa-devel@alsa-project.org, patches@opensource.wolfsonmicro.com
Subject: Re: [PATCH] ASoC: core: Support suspend to disk
Date: Tue, 31 Jan 2012 15:40:50 +0000 [thread overview]
Message-ID: <1328024450.4978.0.camel@odin> (raw)
In-Reply-To: <1328023854-10981-1-git-send-email-broonie@opensource.wolfsonmicro.com>
On Tue, 2012-01-31 at 15:30 +0000, Mark Brown wrote:
> Use the same pm_ops for all system suspend and resume paths. This isn't
> ideal for suspend to disk with older CODECs as we'll suspend and then
> resume the CODEC before powering off all of which takes a long time due
> to VMID ramps but it's very simple to implement and for modern CODECs the
> overhead should be minimal.
>
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> ---
> sound/soc/soc-core.c | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c
> index e25d69c..53fd9d2 100644
> --- a/sound/soc/soc-core.c
> +++ b/sound/soc/soc-core.c
> @@ -1663,8 +1663,7 @@ int snd_soc_poweroff(struct device *dev)
> EXPORT_SYMBOL_GPL(snd_soc_poweroff);
>
> const struct dev_pm_ops snd_soc_pm_ops = {
> - .suspend = snd_soc_suspend,
> - .resume = snd_soc_resume,
> + SET_SYSTEM_SLEEP_PM_OPS(snd_soc_suspend, snd_soc_resume)
> .poweroff = snd_soc_poweroff,
> };
> EXPORT_SYMBOL_GPL(snd_soc_pm_ops);
Acked-by: Liam Girdwood <lrg@ti.com>
prev parent reply other threads:[~2012-01-31 15:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-31 15:30 [PATCH] ASoC: core: Support suspend to disk Mark Brown
2012-01-31 15:40 ` Liam Girdwood [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1328024450.4978.0.camel@odin \
--to=lrg@ti.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=patches@opensource.wolfsonmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).