From: Liam Girdwood <lrg@ti.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>,
"Koul, Vinod" <vinod.koul@intel.com>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH] ASoC: core - Add support for DAI and machine kcontrols.
Date: Mon, 06 Feb 2012 14:16:26 +0000 [thread overview]
Message-ID: <1328537786.6799.16.camel@odin> (raw)
In-Reply-To: <20120206132746.GH3070@opensource.wolfsonmicro.com>
On Mon, 2012-02-06 at 13:27 +0000, Mark Brown wrote:
> On Mon, Feb 06, 2012 at 12:25:18PM +0000, Liam Girdwood wrote:
>
> > sound/soc/mid-x86/mfld_machine.c:238: ret_val = snd_soc_add_codec_controls(codec, mfld_snd_controls,
>
> This looks bogus - looks like the missing fanout mux support which we
> should really fix properly.
Vinod, fyi - something for your todo list ;-)
> > sound/soc/omap/ams-delta.c:575: ret = snd_soc_add_codec_controls(codec, ams_delta_audio_controls,
>
> This one is more fun and probably reasonable for now, though it is about
> the only example of a properly working baseband in mainline.
Liam
next prev parent reply other threads:[~2012-02-06 14:16 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-03 17:43 [PATCH] ASoC: core - Add support for DAI and machine kcontrols Liam Girdwood
2012-02-03 20:46 ` Mark Brown
2012-02-06 10:37 ` Liam Girdwood
2012-02-06 11:09 ` Mark Brown
2012-02-06 12:25 ` Liam Girdwood
2012-02-06 13:27 ` Mark Brown
2012-02-06 14:16 ` Liam Girdwood [this message]
2012-02-06 14:26 ` Mark Brown
2012-02-06 15:11 ` Vinod Koul
2012-02-06 15:17 ` Mark Brown
2012-02-06 18:09 ` Vinod Koul
2012-02-06 18:19 ` Mark Brown
2012-02-04 12:42 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1328537786.6799.16.camel@odin \
--to=lrg@ti.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).